From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB0D6C43219 for ; Thu, 2 May 2019 15:12:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8C78620675 for ; Thu, 2 May 2019 15:12:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GX5GMYb7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726203AbfEBPMo (ORCPT ); Thu, 2 May 2019 11:12:44 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:41622 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726424AbfEBPMo (ORCPT ); Thu, 2 May 2019 11:12:44 -0400 Received: by mail-pg1-f195.google.com with SMTP id f6so1197197pgs.8 for ; Thu, 02 May 2019 08:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Yc2jSz2PdGKy97kcSIVG1XsVhe9Q8as81N746C4MAqs=; b=GX5GMYb7lqCB37WjNBisvRq6uZPdCXLd3VxnXA/ZvLsqJBlfimcWzQT+C1sRNZffzZ AQMipqq1l/fhGJDRbBEUFBJwfhIWOoVx6WwBi6C98fLON6w8AFfj6H2PHrTzEWyHbcRL U4DSVvJ5mjVWHzr0DvVtQE6TQ50Ru7ZEuGw7fTpyTfnB/Z5mmGUjzDP+y1psPBT90gF7 RKree+9JUf5tK9hBSIRAiiIaqa5esjjpA1tk11p+uUm6Cb84OlUnkpVJqy8ciiYLi6wm 4l/gjVEgKgK9hIw8HKni/Rf0tAg3eBsUWMNffOQ7U/tm106+WRuq80tkv3RvguK3cyn5 jjhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Yc2jSz2PdGKy97kcSIVG1XsVhe9Q8as81N746C4MAqs=; b=Fe02H9ZxZjiXEAHR9V6UYXZHQHlDc/MfNX0wsyZo9Knf0vu4spdUEDjcKkJIVjEw09 ZxoaB6bDXxzKANgYWUxDO7lKjGqm/QFdpp3Xq4gW3YTwg6EgqmwAPVFCnXhqeUIs/ovz zT6uxo22cyIKJ9Ou4LJcF+QqcYwe1Wjp05N8A8p8ETsqiwev72W3ObrBxptBqqhd87aF BHVLPNONa61pxMR1QmpFn1JOoZICA3KFvaq6K9au1nh1oNIklR7ykv0CuPCZPswvZonr siyJx8f+m8zRkCHUuCBfVq4NLUydujRoBKM2wrVvfJgYKdCYthE6UtAjhzafOEOqEoYZ 0JmA== X-Gm-Message-State: APjAAAWQ0ILQBBvCw8clEIZCv1TOmbi3HWDOET9AVrCOVZ+x7icZf5lJ ook+sv4j4yfMKwp7He+qfXlamw2hfes= X-Google-Smtp-Source: APXvYqwKEVoTXgCK1Yl04ktfUz1jePba/3rQOqT4m85x+ThB6u+shjyW4ngfqkaeGIYy6EdkKxf/Vw== X-Received: by 2002:a65:60ca:: with SMTP id r10mr4556757pgv.64.1556809962969; Thu, 02 May 2019 08:12:42 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id g65sm8315779pfg.77.2019.05.02.08.12.41 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 May 2019 08:12:41 -0700 (PDT) Date: Thu, 2 May 2019 08:12:44 -0700 From: Bjorn Andersson To: Marc Gonzalez Cc: Linus Walleij , Jeffrey Hugo , Andy Gross , MSM , gpio , Rob Herring , Mark Rutland Subject: Re: [PATCH v1] arm64: dts: qcom: msm8998: Add i2c5 pins Message-ID: <20190502151244.GM2938@tuxbook-pro> References: <20190427045151.GE3137@builder> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon 29 Apr 01:38 PDT 2019, Marc Gonzalez wrote: > On 27/04/2019 06:51, Bjorn Andersson wrote: > > > On Thu 25 Apr 09:06 PDT 2019, Marc Gonzalez wrote: > > > >> Downstream source: > >> https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/msm8998-pinctrl.dtsi?h=LE.UM.1.3.r3.25#n165 > >> > >> Signed-off-by: Marc Gonzalez > >> --- > >> arch/arm64/boot/dts/qcom/msm8998-pins.dtsi | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi b/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi > >> index 6db70acd38ee..d0a95c70d1e7 100644 > >> --- a/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi > >> +++ b/arch/arm64/boot/dts/qcom/msm8998-pins.dtsi > >> @@ -2,6 +2,13 @@ > >> /* Copyright (c) 2018, The Linux Foundation. All rights reserved. */ > >> > >> &tlmm { > >> + i2c5_default: i2c5_default { > >> + pins = "gpio87", "gpio88"; > >> + function = "blsp_i2c5"; > >> + drive-strength = <2>; > >> + bias-disable; > >> + }; > > > > You need to reference this node for it to make a difference. > > Right. I do have a local board file referencing i2c5_default, which I plan > to submit at some point. It contains: > > &blsp1_i2c5 { > status = "ok"; > clock-frequency = <100000>; > pinctrl-names = "default"; > pinctrl-0 = <&i2c5_default>; > }; > > > Also the drive-strength and bias are board specific, so please move this > > to your board dts (and reference the node). > > Wait... Are you saying there should be no drive-strength nor bias definitions > inside msm8998-pins.dtsi? > > $ grep -c 'strength\|bias' arch/arm64/boot/dts/qcom/msm8998-pins.dtsi > 18 > > Why are the SDHC pins different than the I2C pins? > > i2c5 is "tied" to gpio87 and gpio88. Could my board designer "reassign" > these pins to a different HW block? Or is that immutable? > Right, so it makes a lot of sense to have a node in msm8998.dtsi that says that if i2c5 is probed then the associated pinmux should be set up. But the pinconf (drive-strenght, internal vs external bias) are board specific, so this part better go in the board.dts. On sdm845 we put a node with pinmux in the platform.dtsi and then in the board we extend this node with the electrical properties of the board. This works out pretty well, but we haven't gone back and updated the older platforms/boards yet. Regards, Bjorn