From: Lee Jones <lee.jones@linaro.org>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: linux-kernel@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH next 16/25] mfd: Use dev_get_drvdata()
Date: Wed, 8 May 2019 11:32:02 +0100 [thread overview]
Message-ID: <20190508103202.GJ3995@dell> (raw)
In-Reply-To: <20190423075020.173734-17-wangkefeng.wang@huawei.com>
On Tue, 23 Apr 2019, Kefeng Wang wrote:
> Using dev_get_drvdata directly.
>
> Cc: Andy Gross <andy.gross@linaro.org>
> Cc: David Brown <david.brown@linaro.org>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> drivers/mfd/ssbi.c | 2 +-
> drivers/mfd/t7l66xb.c | 12 ++++--------
> drivers/mfd/tc6387xb.c | 12 ++++--------
> drivers/mfd/tc6393xb.c | 21 +++++++--------------
> 4 files changed, 16 insertions(+), 31 deletions(-)
>
> diff --git a/drivers/mfd/ssbi.c b/drivers/mfd/ssbi.c
> index 36b96fee4ce6..50f87d0f9151 100644
> --- a/drivers/mfd/ssbi.c
> +++ b/drivers/mfd/ssbi.c
> @@ -80,7 +80,7 @@ struct ssbi {
> int (*write)(struct ssbi *, u16 addr, const u8 *buf, int len);
> };
>
> -#define to_ssbi(dev) platform_get_drvdata(to_platform_device(dev))
> +#define to_ssbi(dev) dev_get_drvdata(dev)
If you could replace 'to_ssbi(dev)' with 'dev_get_drvdata(dev)' it
would be better.
The rest of the changes look fine.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-05-08 10:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190423075020.173734-1-wangkefeng.wang@huawei.com>
2019-04-23 7:50 ` [PATCH next 16/25] mfd: Use dev_get_drvdata() Kefeng Wang
2019-04-23 7:50 ` Kefeng Wang
2019-05-08 10:32 ` Lee Jones [this message]
2019-05-08 13:52 ` [PATCH next v2] " Kefeng Wang
2019-05-09 6:14 ` Lee Jones
2019-05-09 14:23 ` [PATCH next v3] " Kefeng Wang
2019-05-10 7:02 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508103202.GJ3995@dell \
--to=lee.jones@linaro.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangkefeng.wang@huawei.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox