From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D290C07542 for ; Sat, 25 May 2019 18:16:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 253BC20815 for ; Sat, 25 May 2019 18:16:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E3O488YV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727311AbfEYSQs (ORCPT ); Sat, 25 May 2019 14:16:48 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:46290 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727297AbfEYSQs (ORCPT ); Sat, 25 May 2019 14:16:48 -0400 Received: by mail-pg1-f195.google.com with SMTP id v9so413861pgr.13 for ; Sat, 25 May 2019 11:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/ii9WpqD7iEAJKDcuy2CpZ/y9+8YtSKEyLsD7jWsNAQ=; b=E3O488YVP8TgapmTW0WHrHr5ag7JIOkw2T6nXC6lEd/a1hMULi+DdyrxSINGbd5xGc sUSAbhzND1I0stBU7o+1u8mSI48Daarvhj55rAbL/1vhpivBXI190VPU+y9L/pcIWJE7 bfKWvxY68+2gtByETnQ9w6hEowzfxRrG02eW82rPQv2LvVXCXiPU7lyvE6g0LNSGY7OR kCGHOkkSESFeOZNhP6ieNVyxpo4H2sAbr6pAee6pLlSnvADsydU2iLqzalTMy1kol+f8 +yb/AaoYxpNYnw7UkoFrVGy95QbvWwZnwiPtvDT5gCN88MtAHn3HaUy3ya6MRiAyKObS errQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/ii9WpqD7iEAJKDcuy2CpZ/y9+8YtSKEyLsD7jWsNAQ=; b=MuBbapc+HbzkCS8A5qKNWNGyCXAp27aN/dZYCuVyLbF3IGeRtaVXIMWYwBuax9fjzU lOfLYt6M3btqhUAmD7cOQ/MM6UFgh1CLnE4pKdy65Uv2HGs43WCMicaQvWP1Q0sA8stV k6a93TrGpvQjD9Jmvh2Yrhj4JvYI8qLhyEYcj0WiLJWTfjsJ98OVBy0vG6OJCr/qxhk8 XC4XmtMaCOdbg1RPI8Wnr9Yztxn0fxyN8L05FDv6vqhcsQkFcXP+LMqC7i1mcgCNXNnS 5t4HfZYKFlO1jrNPeWYSVB3IA0JwMD8xYlGPM0X4teKukhNaTo9A8tAeql3RWp/NJaf/ e+fw== X-Gm-Message-State: APjAAAVZYkS/G9l/tHx3fnCfanPRnQ8fUQ2TAI2863EenSuuVCTHNw96 msD7zDgKse1nR1jRJ8YR3rLFLg== X-Google-Smtp-Source: APXvYqxBA7lJ3zAgZZL0FnYp4GQtRBbRIxVuoz1SqGkSgJaOy62aJMDPdmEgBEATozTa5f+xEy64mQ== X-Received: by 2002:aa7:8dc3:: with SMTP id j3mr123366686pfr.141.1558808207644; Sat, 25 May 2019 11:16:47 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id i101sm6691470pje.9.2019.05.25.11.16.45 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 25 May 2019 11:16:46 -0700 (PDT) Date: Sat, 25 May 2019 11:17:14 -0700 From: Bjorn Andersson To: Sai Prakash Ranjan Cc: Andy Gross , David Brown , Stephen Boyd , Rob Herring , Mark Rutland , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 2/4] soc: qcom: Add AOSS QMP driver Message-ID: <20190525181714.GI2085@tuxbook-pro> References: <20190501043734.26706-1-bjorn.andersson@linaro.org> <20190501043734.26706-3-bjorn.andersson@linaro.org> <3d2c61ca-b91b-fdc7-7837-af6a3b71af7e@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3d2c61ca-b91b-fdc7-7837-af6a3b71af7e@codeaurora.org> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sat 25 May 10:53 PDT 2019, Sai Prakash Ranjan wrote: > On 5/1/2019 10:07 AM, Bjorn Andersson wrote: > > The Always On Subsystem (AOSS) Qualcomm Messaging Protocol (QMP) driver > > is used to communicate with the AOSS for certain side-channel requests, > > that are not available through the RPMh interface. > > > > The communication is a very simple synchronous mechanism of messages > > being written in message RAM and a doorbell in the AOSS is rung. As the > > AOSS has processed the message length is cleared and an interrupt is > > fired by the AOSS as acknowledgment. > > > > The driver exposes the QDSS clock as a clock and the low-power state > > associated with the remoteprocs in the system as a set of power-domains. > > > > Signed-off-by: Bjorn Andersson > > --- > > > > Changes since v6: > > - Squash the pd into the same driver as the communication, to simplify > > the interaction. > > - Representing the QDSS clocks as a clock/power domain turns out to > > cascade into a request to make all Coresight drivers have a secondary > > compatible to replace the required bus clock with a required power > > domain. So in v7 this is exposed as a clock instead. > > - Some error checking updates, as reported by Doug. > > > > Thanks for the patch Bjorn. > Tested the QDSS functionality on SDM845 based Cheza board with this > change and it works just fine. > > Tested-by: Sai Prakash Ranjan Thanks for the confirmation Sai! Regards, Bjorn