From: Eduardo Valentin <edubezval@gmail.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: amit.kucheria@linaro.org, agross@kernel.org,
david.brown@linaro.org, rui.zhang@intel.com,
daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH -next] drivers: thermal: tsens: Change hw_id type to int in is_sensor_enabled
Date: Tue, 28 May 2019 19:45:05 -0700 [thread overview]
Message-ID: <20190529024501.GA2355@localhost.localdomain> (raw)
In-Reply-To: <20190527134124.14784-1-yuehaibing@huawei.com>
YueHaibing,
On Mon, May 27, 2019 at 09:41:24PM +0800, YueHaibing wrote:
> Sensor hw_id is int type other u32, is_sensor_enabled
> should use int to compare, this fix smatch warning:
>
> drivers/thermal/qcom/tsens-common.c:72
> is_sensor_enabled() warn: unsigned 'hw_id' is never less than zero.
>
> Fixes: 3e6a8fb33084 ("drivers: thermal: tsens: Add new operation to check if a sensor is enabled")
Thanks for the patch, but we had to revert this commit which was
causing some issues. So, your patch is not applicable.
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thank you anyways.
> ---
> drivers/thermal/qcom/tsens-common.c | 2 +-
> drivers/thermal/qcom/tsens.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
> index 928e8e81ba69..5df4eed84535 100644
> --- a/drivers/thermal/qcom/tsens-common.c
> +++ b/drivers/thermal/qcom/tsens-common.c
> @@ -64,7 +64,7 @@ void compute_intercept_slope(struct tsens_priv *priv, u32 *p1,
> }
> }
>
> -bool is_sensor_enabled(struct tsens_priv *priv, u32 hw_id)
> +bool is_sensor_enabled(struct tsens_priv *priv, int hw_id)
> {
> u32 val;
> int ret;
> diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h
> index eefe3844fb4e..15264806f6a8 100644
> --- a/drivers/thermal/qcom/tsens.h
> +++ b/drivers/thermal/qcom/tsens.h
> @@ -315,7 +315,7 @@ void compute_intercept_slope(struct tsens_priv *priv, u32 *pt1, u32 *pt2, u32 mo
> int init_common(struct tsens_priv *priv);
> int get_temp_tsens_valid(struct tsens_priv *priv, int i, int *temp);
> int get_temp_common(struct tsens_priv *priv, int i, int *temp);
> -bool is_sensor_enabled(struct tsens_priv *priv, u32 hw_id);
> +bool is_sensor_enabled(struct tsens_priv *priv, int hw_id);
>
> /* TSENS target */
> extern const struct tsens_plat_data data_8960;
prev parent reply other threads:[~2019-05-29 2:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 13:41 [PATCH -next] drivers: thermal: tsens: Change hw_id type to int in is_sensor_enabled YueHaibing
2019-05-29 2:45 ` Eduardo Valentin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190529024501.GA2355@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).