From: Stephen Boyd <sboyd@kernel.org>
To: Philippe Mazenauer <philippe.mazenauer@outlook.de>
Cc: Philippe Mazenauer <philippe.mazenauer@outlook.de>,
Andy Gross <agross@kernel.org>,
David Brown <david.brown@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
"open list:ARM/QUALCOMM SUPPORT" <linux-arm-msm@vger.kernel.org>,
"open list:COMMON CLK FRAMEWORK" <linux-clk@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: qcom: clk-rpm: Removed unused macros/variable
Date: Thu, 06 Jun 2019 10:32:30 -0700 [thread overview]
Message-ID: <20190606173231.C64192083D@mail.kernel.org> (raw)
In-Reply-To: <VI1PR07MB4432BB9A401E0202C4D7D948FD070@VI1PR07MB4432.eurprd07.prod.outlook.com>
Quoting Philippe Mazenauer (2019-05-21 02:45:25)
> Removed macros DEFINE_CLK_RPM_PXO_BRANCH, DEFINE_CLK_RPM_CXO_BRANCH and
> variable 'clk_rpm_branch_ops'. The macros and variable are not used in the
> file.
>
> As the variable, which is used by the macros, is declared static, the
> macros can't be used outside the file, are unused.
>
> ../drivers/clk/qcom/clk-rpm.c:461:29: warning: ‘clk_rpm_branch_ops’ defined but not used [-Wunused-const-variable=]
> static const struct clk_ops clk_rpm_branch_ops = {
> ^~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Philippe Mazenauer <philippe.mazenauer@outlook.de>
Yeah it's dead code but the qcom folks wanted to manage the crystal with
this code so maybe we should just leave it around for them. Or they
could dig it out of the git history.
prev parent reply other threads:[~2019-06-06 17:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 9:45 [PATCH] clk: qcom: clk-rpm: Removed unused macros/variable Philippe Mazenauer
2019-06-06 17:32 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606173231.C64192083D@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=philippe.mazenauer@outlook.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).