From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 511D7C04AB5 for ; Thu, 6 Jun 2019 17:32:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1E92F2083E for ; Thu, 6 Jun 2019 17:32:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559842353; bh=6Bj6NJLiqPYiupjoKhEXTA+eM9B1Ma8fK74v78tg4IQ=; h=In-Reply-To:References:To:Subject:From:Cc:Date:List-ID:From; b=R5mhQ9yzwT5ZiFZkEDzlKsjYdnhIgy0MITI822OejpCSqgC90tHRp6qOUNz5/QByK K/JplMrAtYcCKM5G1TWf8WB2sO2Omz/ldgufbDb2epu/f7UJlnJWl6n++27nS9dZlI tcbVjvt0EShlhc2YNxKyX5JFVooY91DNVLOP02jc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728650AbfFFRcc (ORCPT ); Thu, 6 Jun 2019 13:32:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:57892 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726924AbfFFRcc (ORCPT ); Thu, 6 Jun 2019 13:32:32 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C64192083D; Thu, 6 Jun 2019 17:32:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559842351; bh=6Bj6NJLiqPYiupjoKhEXTA+eM9B1Ma8fK74v78tg4IQ=; h=In-Reply-To:References:To:Subject:From:Cc:Date:From; b=Gc5mJ30rK4+KTjujOJr4Un4VN1suuSTTE/l+Gg5brBl7cMnaba3IbDkkiTAx6IN45 VytCZ5mWi5eWL0nzGzWrOUQoVEJOp9LkltE1Mz3IzNXk40SHGJWeurDW15Gb16/m+t FEeeBUS4puzIk3Y8N8OvKtWsP67HYCQ9pU9SCxBU= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: To: Philippe Mazenauer Subject: Re: [PATCH] clk: qcom: clk-rpm: Removed unused macros/variable From: Stephen Boyd Cc: Philippe Mazenauer , Andy Gross , David Brown , Michael Turquette , "open list:ARM/QUALCOMM SUPPORT" , "open list:COMMON CLK FRAMEWORK" , open list User-Agent: alot/0.8.1 Date: Thu, 06 Jun 2019 10:32:30 -0700 Message-Id: <20190606173231.C64192083D@mail.kernel.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Philippe Mazenauer (2019-05-21 02:45:25) > Removed macros DEFINE_CLK_RPM_PXO_BRANCH, DEFINE_CLK_RPM_CXO_BRANCH and > variable 'clk_rpm_branch_ops'. The macros and variable are not used in the > file. >=20 > As the variable, which is used by the macros, is declared static, the > macros can't be used outside the file, are unused. >=20 > ../drivers/clk/qcom/clk-rpm.c:461:29: warning: =E2=80=98clk_rpm_branch_op= s=E2=80=99 defined but not used [-Wunused-const-variable=3D] > static const struct clk_ops clk_rpm_branch_ops =3D { > ^~~~~~~~~~~~~~~~~~ >=20 > Signed-off-by: Philippe Mazenauer Yeah it's dead code but the qcom folks wanted to manage the crystal with this code so maybe we should just leave it around for them. Or they could dig it out of the git history.