From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, T_DKIMWL_WL_HIGH autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C617BC468BD for ; Fri, 7 Jun 2019 17:43:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A7C92146E for ; Fri, 7 Jun 2019 17:43:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559929434; bh=gXf4g7NtG4W1D13TFXtjWxdNR+9w+PrxucbuPxyrkv0=; h=In-Reply-To:References:To:From:Subject:Cc:Date:List-ID:From; b=0azLHRiCX7cBEXtiWTSeCxRePHb8IWqbWITgHjKyDF90nAtUyA/3c3a6SmErKJQTC j/Bf1b2I/EaGA32UNPJHoXW0v5TE/weh/ph/IcPvzo262sThj+w8pqCoac1sEKx3ra 4SYl0TqSAnwF1/rgF/RvIJIn36RZoml8YXccb7vU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728727AbfFGRny (ORCPT ); Fri, 7 Jun 2019 13:43:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:60242 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728684AbfFGRny (ORCPT ); Fri, 7 Jun 2019 13:43:54 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 31EDA208C3; Fri, 7 Jun 2019 17:43:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559929433; bh=gXf4g7NtG4W1D13TFXtjWxdNR+9w+PrxucbuPxyrkv0=; h=In-Reply-To:References:To:From:Subject:Cc:Date:From; b=mURIPArJDMacO6hbAVcSQ9mKR1J1RgcZijTvGQT4aBispznA1+9DnWRL1BqsVMs3L tIm7vTdactHn1yPF/DTnSApajeXtsJKvmIW6ZRw8d39geCQxXeo0RHmHhLOwrONtuH nf2g/9TQ7iVz6GhbSt+cBDRI6WMrrTi+9f0wtKIg= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190607101234.30449-2-vkoul@kernel.org> References: <20190607101234.30449-1-vkoul@kernel.org> <20190607101234.30449-2-vkoul@kernel.org> To: Rob Herring , Vinod Koul From: Stephen Boyd Subject: Re: [PATCH 2/2] clk: qcom: gcc: Add global clock controller driver for SM8150 Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Deepak Katragadda , Andy Gross , David Brown , Michael Turquette , Mark Rutland , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, Taniya Das , Vinod Koul User-Agent: alot/0.8.1 Date: Fri, 07 Jun 2019 10:43:52 -0700 Message-Id: <20190607174353.31EDA208C3@mail.kernel.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Vinod Koul (2019-06-07 03:12:34) > diff --git a/drivers/clk/qcom/gcc-sm8150.c b/drivers/clk/qcom/gcc-sm8150.c > new file mode 100644 > index 000000000000..1cbc884444c9 > --- /dev/null > +++ b/drivers/clk/qcom/gcc-sm8150.c > +static const struct parent_map gcc_parent_map_0[] =3D { > + { P_BI_TCXO, 0 }, > + { P_GPLL0_OUT_MAIN, 1 }, > + { P_GPLL0_OUT_EVEN, 6 }, > + { P_CORE_BI_PLL_TEST_SE, 7 }, > +}; > + > +static const char * const gcc_parent_names_0[] =3D { We have a new way of specifying clk parents now. Can you use that instead of using strings everywhere? > + "bi_tcxo", > + "gpll0", > + "gpll0_out_even", > + "core_bi_pll_test_se",