Re: [PATCH v2 4/5] clk: qcom: clk-alpha-pll: Add support for Trion PLLs

Vinod Koul
2019-06-17T06:20:08Z

On 17-06-19, 11:40, Taniya Das wrote:
> Hi Vinod,
>
> On 6/14/2019 11:12 AM, Vinod Koul wrote:
> > Hi Taniya,
> >
> > On 13-06-19, 08:34, Taniya Das wrote:
> > > Hi Vinod,
> > >
> > > The trion PLL needs to be configured before it is enabled. The PLL cannot
> > > LOCK without the calibration.
> > >
> > > Could you please add "clk_trion_pll_configure()" function?
> >
> > First it is not recommended to top post! Please reply inline.
> >
> > Yes I did see that, I will check that. Is there any way to find PLL is
> > configured or not? I want to avoid using inited variable as done in
> > downstream.
> >
>
> These PLLs which are controlled by High Level OS would not be configured and
> we should not rely on the configurations which are done previously for these
> PLLs.

Thanks, would it make sense then to do the initialization of the PLL in
driver probe. That would ensure HLOS is configuring them properly.

--
~Vinod