From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DBC9C31E44 for ; Mon, 17 Jun 2019 04:26:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35A062189F for ; Mon, 17 Jun 2019 04:26:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="u3kYQd8f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725823AbfFQE0B (ORCPT ); Mon, 17 Jun 2019 00:26:01 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:44652 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726043AbfFQE0B (ORCPT ); Mon, 17 Jun 2019 00:26:01 -0400 Received: by mail-pg1-f194.google.com with SMTP id n2so5017247pgp.11 for ; Sun, 16 Jun 2019 21:26:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qysG3nPvhaAKSI9smIDIahzbODrHWbyjnj/GEJuZrXc=; b=u3kYQd8fFjb8wpRDhwAa5rO79xLm9+fj8aqWcR2QSKCMXe2jRFJkOBK2DwnPsnNUrZ Yb8M9Tbrlj9cEnJJtGXUmhl64KEdwxX/bCgynnsWorkVUsQUw9zjJc1Vo5xkQE/Muadi FzcfohxA99T67AJNG4hw0HWjdMYJrUtCg7QM/kxIgjz0Gm4oyEmGDjPcHcnsayJrYhVu dMEv3DIceOVTok1s1OgSH1aMjgEvOQtJoHd7Sjb7/fKi7K8CvKcHclOauZXnHEHm9LIN lJBGRAnFuf+vVDw5VmpBc1e3sDTSoWLjGDlq5HVnKTM1ab7HlG68Ys0yiJ8SUcWv+ezD D3xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qysG3nPvhaAKSI9smIDIahzbODrHWbyjnj/GEJuZrXc=; b=ecM0T1TFCsW0a65JYQ8tSpoJBntvdY6a1n9ng8Y8lGinA5qm0It90wjT59gn6tuIfU Sy9SwlJOjxjxL/IsuPuL3tflJkH/M7TIXnlpxBRMAXyV8jrDzKsnlh9V0xobg7hWM3Ew 8Eph+hcZi49qVF+WwkagtFnD5jtXDZlI/k19HxPaMmsupCHYKiSDnhDQFWIqKeI5rt/f dI3QKDG9jStunNP7WtkIPoWOhod4XhjCBjblXb/YWTn66VS6rG31yElnwypcq8Xfg3YB OZ3k/UCqzu0BmKuKIimNNNKXJkAZ3dJGNl4lvT0++I/0+55zFXaPENSxfksObn1/RZR3 t15w== X-Gm-Message-State: APjAAAUZhDu+auvwwOZ+pxea44tHytRQ9Ra6hw3d+Z5VJ6HGR4uUyRQ9 yLwCi3k7HyOzkg9XvrwJ1bLZJQ== X-Google-Smtp-Source: APXvYqyJeQVOiKNn2uH00eViwNZ2A0p4ruEvZhX33ERCjJ1TqcY9/NohX8ZMrMRGnZinEjIAN8823w== X-Received: by 2002:a17:90a:9bc5:: with SMTP id b5mr24261795pjw.109.1560745560700; Sun, 16 Jun 2019 21:26:00 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id p9sm9513938pjo.26.2019.06.16.21.25.59 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 16 Jun 2019 21:26:00 -0700 (PDT) Date: Sun, 16 Jun 2019 21:26:49 -0700 From: Bjorn Andersson To: Vinod Koul Cc: Stephen Boyd , linux-arm-msm@vger.kernel.org, Andy Gross , David Brown , Michael Turquette , linux-clk@vger.kernel.org Subject: Re: [PATCH v2 3/5] clk: qcom: gcc-qcs404: Add MODULE_ALIAS Message-ID: <20190617042649.GF750@tuxbook-pro> References: <20190612091722.9377-1-vkoul@kernel.org> <20190612091722.9377-4-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190612091722.9377-4-vkoul@kernel.org> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed 12 Jun 02:17 PDT 2019, Vinod Koul wrote: > MODULE_ALIAS was missing for this driver which can be built as a > module, so add the MODULE_ALIAS. > MODULE_ALIAS() serves the purpose of providing an module alias for the driver, which allows the automatic kernel module loader to insmod the driver as a device needing it is being registered. When the device is instantiated through the OF code path the compatible will be matched against the MODULE_DEVICE_TABLE(of, ) and if the device is programmatically registered (through platform_device_register_*()) then the alias "platform:XYZ" will be used. So, unless we're going to support module autoloading of this driver from a board file no alias should be needed. Regards, Bjorn > Signed-off-by: Vinod Koul > --- > drivers/clk/qcom/gcc-qcs404.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c > index a54807eb3b28..eb3ac7a26fb8 100644 > --- a/drivers/clk/qcom/gcc-qcs404.c > +++ b/drivers/clk/qcom/gcc-qcs404.c > @@ -2828,3 +2828,4 @@ module_exit(gcc_qcs404_exit); > > MODULE_DESCRIPTION("Qualcomm GCC QCS404 Driver"); > MODULE_LICENSE("GPL v2"); > +MODULE_ALIAS("platform:gcc-qcs404"); > -- > 2.20.1 >