Re: [PATCH v2 2/5] clk: qcom: clk-alpha-pll: Remove post_div_table checks

Bjorn Andersson
2019-06-17T04:27:38Z

On Wed 12 Jun 02:17 PDT 2019, Vinod Koul wrote:

> We want users to code properly and fix the post_div_table missing and
> not reply on core to check. So remove the post_div_table check.
>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> drivers/clk/qcom/clk-alpha-pll.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c
> index b48707693ffd..2c6773188761 100644
> --- a/drivers/clk/qcom/clk-alpha-pll.c
> +++ b/drivers/clk/qcom/clk-alpha-pll.c
> @@ -1036,11 +1036,6 @@ static unsigned long clk_alpha_pll_postdiv_fabia_recalc_rate(struct clk_hw *hw,
> u32 i, div = 1, val;
> int ret;
>
> - if (!pll->post_div_table) {
> - pr_err("Missing the post_div_table for the PLL\n");
> - return -EINVAL;
> - }
> -
> ret = regmap_read(pll->clkr.regmap, PLL_USER_CTL(pll), &val);
> if (ret)
> return ret;
> @@ -1063,11 +1058,6 @@ static long clk_alpha_pll_postdiv_fabia_round_rate(struct clk_hw *hw,
> {
> struct clk_alpha_pll_postdiv *pll = to_clk_alpha_pll_postdiv(hw);
>
> - if (!pll->post_div_table) {
> - pr_err("Missing the post_div_table for the PLL\n");
> - return -EINVAL;
> - }
> -
> return divider_round_rate(hw, rate, prate, pll->post_div_table,
> pll->width, CLK_DIVIDER_ROUND_CLOSEST);
> }
> @@ -1089,11 +1079,6 @@ static int clk_alpha_pll_postdiv_fabia_set_rate(struct clk_hw *hw,
> if (val & PLL_VOTE_FSM_ENA)
> return 0;
>
> - if (!pll->post_div_table) {
> - pr_err("Missing the post_div_table for the PLL\n");
> - return -EINVAL;
> - }
> -
> div = DIV_ROUND_UP_ULL(parent_rate, rate);
> for (i = 0; i < pll->num_post_div; i++) {
> if (pll->post_div_table[i].div == div) {
> --
> 2.20.1
>