From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA3F3C5B57E for ; Sun, 30 Jun 2019 14:22:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F69920665 for ; Sun, 30 Jun 2019 14:22:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726509AbfF3OWa (ORCPT ); Sun, 30 Jun 2019 10:22:30 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:42916 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726500AbfF3OW3 (ORCPT ); Sun, 30 Jun 2019 10:22:29 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 4D8FC80415; Sun, 30 Jun 2019 16:22:20 +0200 (CEST) Date: Sun, 30 Jun 2019 16:22:19 +0200 From: Sam Ravnborg To: dri-devel@lists.freedesktop.org, Rob Clark , Daniel Vetter , Jordan Crouse , Jeykumar Sankaran , Maarten Lankhorst Cc: Paul Kocialkowski , Maxime Ripard , freedreno@lists.freedesktop.org, Carsten Behling , Jonathan Marek , David Airlie , Mamta Shukla , Bruce Wang , Shayenne Moura , Sibi Sankar , linux-arm-msm@vger.kernel.org, Todor Tomov , Sean Paul Subject: Re: [PATCH v1] drm/msm: drop use of drmP.h Message-ID: <20190630142218.GB5444@ravnborg.org> References: <20190630052133.6175-1-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190630052133.6175-1-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=pGLkceISAAAA:8 a=LpQP-O61AAAA:8 a=QyXUC8HyAAAA:8 a=7gkXJVJtAAAA:8 a=cm27Pg_UAAAA:8 a=RAbU-raeAAAA:8 a=mK_AVkanAAAA:8 a=P-IC7800AAAA:8 a=KKAkSRfTAAAA:8 a=VwQbUJbxAAAA:8 a=e5mUnYsNAAAA:8 a=mDV3o1hIAAAA:8 a=vMu0rPO_DUfMDCNS_WUA:9 a=CjuIK1q_8ugA:10 a=pioyyrs4ZptJ924tMmac:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=xmb-EsYY8bH0VWELuYED:22 a=JiizpSU_mAIq9zsZDqn2:22 a=3gWm3jAn84ENXaBijsEo:22 a=d3PnA9EDa4IxuAV0gXij:22 a=cvBusfyB2V15izCimMoJ:22 a=AjGcO6oz07-iQ99wixmX:22 a=Vxmtnl_E_bksehYqCbjh:22 a=_FVE-zBwftR9WsbkzFJk:22 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Strange... git send-email did not send this to all recipients listed as Cc: ?!?!? Added the following persons missing in the mail: > Cc: Rob Clark > Cc: Daniel Vetter > Cc: Jordan Crouse > Cc: Jeykumar Sankaran > Cc: Maarten Lankhorst After sending out 40 mails I am not too happy to discover this. Added the persons missing. Sam On Sun, Jun 30, 2019 at 07:21:33AM +0200, Sam Ravnborg wrote: > Drop the deprecated drmP.h header file, and trim msm_drv.h > to the relevant include files. > > This resulted in a suprisingly many edits as many files relied > on headers included via msm_drv.h. > But msm_drv.h is not supposed to carry include files it do not need, so > the individual files have to include what extra they needs. > > Signed-off-by: Sam Ravnborg > Cc: Rob Clark > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: Jordan Crouse > Cc: Jeykumar Sankaran > Cc: Bruce Wang > Cc: Shayenne Moura > Cc: Mamta Shukla > Cc: Jonathan Marek > Cc: Carsten Behling > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Paul Kocialkowski > Cc: Sibi Sankar > Cc: Todor Tomov > Cc: linux-arm-msm@vger.kernel.org > Cc: freedreno@lists.freedesktop.org > --- > The patch is build tested using several configs and > several architectures (including arm, arm64, x86). > > The patch is based on drm-misc. > > If patch is OK, please apply to your tree > as this driver is maintained outside drm-misc. > > I am happy to rebase on another tree, just let me know. > > Sam > > drivers/gpu/drm/msm/adreno/a5xx_debugfs.c | 4 +++- > drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 ++ > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 8 +++++--- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 - > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 6 ++++-- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 2 ++ > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 1 + > drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 1 + > drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 1 + > drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c | 1 + > drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 3 +++ > drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c | 2 ++ > drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c | 2 ++ > drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 3 +++ > drivers/gpu/drm/msm/disp/mdp5/mdp5_irq.c | 1 + > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 6 ++++++ > drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c | 2 ++ > drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c | 1 + > drivers/gpu/drm/msm/dsi/dsi_host.c | 8 +++++--- > drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c | 2 ++ > drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c | 2 ++ > drivers/gpu/drm/msm/dsi/pll/dsi_pll.h | 2 +- > drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 2 ++ > drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 1 + > drivers/gpu/drm/msm/hdmi/hdmi_phy_8996.c | 1 + > drivers/gpu/drm/msm/hdmi/hdmi_phy_8x60.c | 2 ++ > drivers/gpu/drm/msm/hdmi/hdmi_pll_8960.c | 2 ++ > drivers/gpu/drm/msm/msm_atomic.c | 1 + > drivers/gpu/drm/msm/msm_debugfs.c | 5 +++++ > drivers/gpu/drm/msm/msm_drv.c | 10 +++++++++- > drivers/gpu/drm/msm/msm_drv.h | 1 - > drivers/gpu/drm/msm/msm_fb.c | 2 ++ > drivers/gpu/drm/msm/msm_fbdev.c | 1 + > drivers/gpu/drm/msm/msm_gem.c | 2 ++ > drivers/gpu/drm/msm/msm_gem_prime.c | 6 ++++-- > drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++++ > drivers/gpu/drm/msm/msm_gpummu.c | 2 ++ > drivers/gpu/drm/msm/msm_perf.c | 3 +++ > drivers/gpu/drm/msm/msm_rd.c | 7 +++++-- > drivers/gpu/drm/msm/msm_submitqueue.c | 2 ++ > 40 files changed, 98 insertions(+), 17 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a5xx_debugfs.c b/drivers/gpu/drm/msm/adreno/a5xx_debugfs.c > index 3041c500c5cd..2eafad831226 100644 > --- a/drivers/gpu/drm/msm/adreno/a5xx_debugfs.c > +++ b/drivers/gpu/drm/msm/adreno/a5xx_debugfs.c > @@ -2,9 +2,11 @@ > /* Copyright (c) 2016-2017 The Linux Foundation. All rights reserved. > */ > > - > #include > #include > + > +#include > +#include > #include > > #include "a5xx_gpu.h" > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > index 3772f745589d..053ad94a12c6 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c > @@ -20,11 +20,13 @@ > #include > #include > #include > + > #include > #include > #include > #include > #include > +#include > > #include "dpu_kms.h" > #include "dpu_hw_lm.h" > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > index 82bf16d61a45..57c5f9443a4a 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c > @@ -17,14 +17,16 @@ > */ > > #define pr_fmt(fmt) "[drm:%s:%d] " fmt, __func__, __LINE__ > -#include > #include > +#include > #include > > -#include "msm_drv.h" > -#include "dpu_kms.h" > #include > +#include > #include > + > +#include "msm_drv.h" > +#include "dpu_kms.h" > #include "dpu_hwio.h" > #include "dpu_hw_catalog.h" > #include "dpu_hw_intf.h" > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h > index 90f439812088..ec76b8687a98 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h > @@ -9,7 +9,6 @@ > #include > #include > #include > -#include > > /** > * Max hardware block count: For ex: max 12 SSPP pipes or > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > index 885bf88afa3e..57f33bc26916 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > @@ -18,10 +18,12 @@ > > #define pr_fmt(fmt) "[drm:%s:%d] " fmt, __func__, __LINE__ > > -#include > #include > -#include > #include > +#include > + > +#include > +#include > > #include "msm_drv.h" > #include "msm_mmu.h" > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h > index 31e9ef96ca5d..297fbef8e5d7 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h > @@ -19,6 +19,8 @@ > #ifndef __DPU_KMS_H__ > #define __DPU_KMS_H__ > > +#include > + > #include "msm_drv.h" > #include "msm_kms.h" > #include "msm_mmu.h" > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > index a4d7ab97bb8e..f5f312d41853 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c > @@ -22,6 +22,7 @@ > #include > > #include > +#include > #include > > #include "msm_drv.h" > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c > index 3c9236bb291c..0ae820e20b40 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c > @@ -5,6 +5,7 @@ > #define pr_fmt(fmt) "[drm:%s:%d] " fmt, __func__, __LINE__ > > #include > +#include > > #include "dpu_vbif.h" > #include "dpu_hw_vbif.h" > diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c > index 0cfd4c06b610..a8a58ea826d6 100644 > --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c > +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c > @@ -19,6 +19,7 @@ > #include > #include > #include > +#include > > #include "mdp4_kms.h" > > diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c > index b764d7f10312..8b284b2d9489 100644 > --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c > +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_irq.c > @@ -16,6 +16,7 @@ > */ > > #include > +#include > > #include "msm_drv.h" > #include "mdp4_kms.h" > diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c > index e437aa806f7b..7e7c03936af0 100644 > --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c > +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c > @@ -15,6 +15,9 @@ > * this program. If not, see . > */ > > +#include > + > +#include > > #include "msm_drv.h" > #include "msm_gem.h" > diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c > index df6f9803a1d7..f6062fe15bd0 100644 > --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c > +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_lcdc_encoder.c > @@ -16,6 +16,8 @@ > * this program. If not, see . > */ > > +#include > + > #include > #include > > diff --git a/drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c b/drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c > index 005066f7154d..b202faee2492 100644 > --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c > +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c > @@ -15,6 +15,8 @@ > * this program. If not, see . > */ > > +#include > + > #include "mdp4_kms.h" > > #define DOWN_SCALE_MAX 8 > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c > index c3751c95b452..1017246bc3db 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c > @@ -17,10 +17,13 @@ > */ > > #include > + > #include > #include > #include > +#include > #include > +#include > > #include "mdp5_kms.h" > > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_irq.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_irq.c > index 280e368bc9bb..a62f9c06d3c1 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_irq.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_irq.c > @@ -18,6 +18,7 @@ > #include > > #include > +#include > > #include "msm_drv.h" > #include "mdp5_kms.h" > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > index 97179bec8902..ff000b3d39c3 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > @@ -16,8 +16,14 @@ > * this program. If not, see . > */ > > +#include > #include > > +#include > +#include > +#include > +#include > + > #include "msm_drv.h" > #include "msm_gem.h" > #include "msm_mmu.h" > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c > index 1105c2433f14..55b0b60893dc 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_plane.c > @@ -16,7 +16,9 @@ > * this program. If not, see . > */ > > +#include > #include > + > #include "mdp5_kms.h" > > struct mdp5_plane { > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c > index 2834837f4d3e..620413f9367f 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c > @@ -16,6 +16,7 @@ > * this program. If not, see . > */ > > +#include > #include > > #include "mdp5_kms.h" > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c > index dbf490176c2c..95b32f167a79 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > @@ -5,19 +5,21 @@ > > #include > #include > +#include > #include > #include > #include > #include > +#include > #include > #include > +#include > #include > #include > -#include > +#include > #include > #include > -#include > -#include > + > #include