From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Rob Clark <robdclark@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
Sean Paul <seanpaul@chromium.org>,
Rob Clark <robdclark@chromium.org>,
Andrzej Hajda <a.hajda@samsung.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] drm/bridge: ti-sn65dsi86: add link to datasheet
Date: Thu, 4 Jul 2019 15:32:11 +0300 [thread overview]
Message-ID: <20190704123211.GF6569@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20190702154419.20812-2-robdclark@gmail.com>
Hi Rob,
Thank you for the patch.
On Tue, Jul 02, 2019 at 08:44:16AM -0700, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> The bridge has pretty good docs, lets add a link to make them easier to
> find.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/bridge/ti-sn65dsi86.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> index bcca9173c72a..f1a2493b86d9 100644
> --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> @@ -1,6 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0
> /*
> * Copyright (c) 2018, The Linux Foundation. All rights reserved.
> + * datasheet: http://www.ti.com/lit/ds/symlink/sn65dsi86.pdf
It's in the DT bindings and it's easy to find so I'm not sure it adds
lots of value to mention it here, but I don't feel very strongly about
it, so if you think it can be useful I don't mind. I would however put a
blank line after the copyright line in that case, and
s/datasheet/Datasheet/
> */
>
> #include <linux/clk.h>
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2019-07-04 12:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190702154436epcas2p3fdaaa095c15a116a0be7e5313469151f@epcas2p3.samsung.com>
2019-07-02 15:44 ` [PATCH 0/3] drm/bridge: ti-sn65dsi86: debugfs and mode_flags fix Rob Clark
2019-07-02 15:44 ` [PATCH 1/3] drm/bridge: ti-sn65dsi86: add link to datasheet Rob Clark
2019-07-02 17:03 ` Jeffrey Hugo
2019-07-04 12:26 ` Andrzej Hajda
2019-07-04 12:32 ` Laurent Pinchart [this message]
2019-07-02 15:44 ` [PATCH 2/3] drm/bridge: ti-sn65dsi86: add debugfs Rob Clark
2019-07-02 17:05 ` Jeffrey Hugo
2019-07-04 12:31 ` Andrzej Hajda
2019-07-04 12:35 ` Laurent Pinchart
2019-07-04 13:56 ` Rob Clark
2019-07-04 21:10 ` Laurent Pinchart
2019-07-02 15:44 ` [PATCH 3/3] drm/bridge: ti-sn65dsi86: correct dsi mode_flags Rob Clark
2019-07-02 17:09 ` Jeffrey Hugo
2019-07-02 17:12 ` Rob Clark
2019-07-02 17:23 ` Jeffrey Hugo
2019-07-04 12:33 ` Andrzej Hajda
2019-07-04 13:18 ` [PATCH 0/3] drm/bridge: ti-sn65dsi86: debugfs and mode_flags fix Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704123211.GF6569@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox