From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: ohad@wizery.com, jeffrey.l.hugo@gmail.com, agross@kernel.org,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] remoteproc: qcom: q6v5-mss: Fix build error without QCOM_MDT_LOADER
Date: Thu, 4 Jul 2019 11:22:05 -0700 [thread overview]
Message-ID: <20190704182205.GH1263@builder> (raw)
In-Reply-To: <20190704064649.51748-1-yuehaibing@huawei.com>
On Wed 03 Jul 23:46 PDT 2019, YueHaibing wrote:
> If QCOM_Q6V5_MSS is set but QCOM_MDT_LOADER is not,
> building will fails:
>
> drivers/remoteproc/qcom_q6v5_mss.o: In function `q6v5_start':
> qcom_q6v5_mss.c:(.text+0x3260): undefined reference to `qcom_mdt_read_metadata'
>
> Add QCOM_MDT_LOADER dependency for QCOM_Q6V5_MSS.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: f04b91383456 ("remoteproc: qcom: q6v5-mss: Support loading non-split images")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks for catching this, Applied.
Regards,
Bjorn
> ---
> drivers/remoteproc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 9b0f0cb..28ed306 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -116,6 +116,7 @@ config QCOM_Q6V5_MSS
> depends on RPMSG_QCOM_GLINK_SMEM || RPMSG_QCOM_GLINK_SMEM=n
> depends on QCOM_SYSMON || QCOM_SYSMON=n
> select MFD_SYSCON
> + select QCOM_MDT_LOADER
> select QCOM_Q6V5_COMMON
> select QCOM_RPROC_COMMON
> select QCOM_SCM
> --
> 2.7.4
>
>
prev parent reply other threads:[~2019-07-04 18:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 6:46 [PATCH] remoteproc: qcom: q6v5-mss: Fix build error without QCOM_MDT_LOADER YueHaibing
2019-07-04 18:22 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704182205.GH1263@builder \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).