* [PATCH] remoteproc: qcom: q6v5-mss: Fix build error without QCOM_MDT_LOADER
@ 2019-07-04 6:46 YueHaibing
2019-07-04 18:22 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-07-04 6:46 UTC (permalink / raw)
To: ohad, bjorn.andersson, jeffrey.l.hugo, agross
Cc: linux-kernel, linux-remoteproc, linux-arm-msm, YueHaibing
If QCOM_Q6V5_MSS is set but QCOM_MDT_LOADER is not,
building will fails:
drivers/remoteproc/qcom_q6v5_mss.o: In function `q6v5_start':
qcom_q6v5_mss.c:(.text+0x3260): undefined reference to `qcom_mdt_read_metadata'
Add QCOM_MDT_LOADER dependency for QCOM_Q6V5_MSS.
Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: f04b91383456 ("remoteproc: qcom: q6v5-mss: Support loading non-split images")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/remoteproc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
index 9b0f0cb..28ed306 100644
--- a/drivers/remoteproc/Kconfig
+++ b/drivers/remoteproc/Kconfig
@@ -116,6 +116,7 @@ config QCOM_Q6V5_MSS
depends on RPMSG_QCOM_GLINK_SMEM || RPMSG_QCOM_GLINK_SMEM=n
depends on QCOM_SYSMON || QCOM_SYSMON=n
select MFD_SYSCON
+ select QCOM_MDT_LOADER
select QCOM_Q6V5_COMMON
select QCOM_RPROC_COMMON
select QCOM_SCM
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] remoteproc: qcom: q6v5-mss: Fix build error without QCOM_MDT_LOADER
2019-07-04 6:46 [PATCH] remoteproc: qcom: q6v5-mss: Fix build error without QCOM_MDT_LOADER YueHaibing
@ 2019-07-04 18:22 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2019-07-04 18:22 UTC (permalink / raw)
To: YueHaibing
Cc: ohad, jeffrey.l.hugo, agross, linux-kernel, linux-remoteproc,
linux-arm-msm
On Wed 03 Jul 23:46 PDT 2019, YueHaibing wrote:
> If QCOM_Q6V5_MSS is set but QCOM_MDT_LOADER is not,
> building will fails:
>
> drivers/remoteproc/qcom_q6v5_mss.o: In function `q6v5_start':
> qcom_q6v5_mss.c:(.text+0x3260): undefined reference to `qcom_mdt_read_metadata'
>
> Add QCOM_MDT_LOADER dependency for QCOM_Q6V5_MSS.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: f04b91383456 ("remoteproc: qcom: q6v5-mss: Support loading non-split images")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks for catching this, Applied.
Regards,
Bjorn
> ---
> drivers/remoteproc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 9b0f0cb..28ed306 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -116,6 +116,7 @@ config QCOM_Q6V5_MSS
> depends on RPMSG_QCOM_GLINK_SMEM || RPMSG_QCOM_GLINK_SMEM=n
> depends on QCOM_SYSMON || QCOM_SYSMON=n
> select MFD_SYSCON
> + select QCOM_MDT_LOADER
> select QCOM_Q6V5_COMMON
> select QCOM_RPROC_COMMON
> select QCOM_SCM
> --
> 2.7.4
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-04 18:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-04 6:46 [PATCH] remoteproc: qcom: q6v5-mss: Fix build error without QCOM_MDT_LOADER YueHaibing
2019-07-04 18:22 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).