From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2CAEC46499 for ; Fri, 5 Jul 2019 17:21:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8176220989 for ; Fri, 5 Jul 2019 17:21:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727317AbfGERVM (ORCPT ); Fri, 5 Jul 2019 13:21:12 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:41740 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725813AbfGERVL (ORCPT ); Fri, 5 Jul 2019 13:21:11 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 5CCDD803B4; Fri, 5 Jul 2019 19:21:06 +0200 (CEST) Date: Fri, 5 Jul 2019 19:20:58 +0200 From: Sam Ravnborg To: Jeffrey Hugo Cc: thierry.reding@gmail.com, airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, mark.rutland@arm.com, bjorn.andersson@linaro.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] drm/panel: simple: Add support for Sharp LD-D5116Z01B panel Message-ID: <20190705172058.GA2788@ravnborg.org> References: <20190705165450.329-1-jeffrey.l.hugo@gmail.com> <20190705165755.515-1-jeffrey.l.hugo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190705165755.515-1-jeffrey.l.hugo@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=pGLkceISAAAA:8 a=OJLUmJNqMcVkCySmTlIA:9 a=CjuIK1q_8ugA:10 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Jeffrey. Patch looks good, but there is a few fields that are not initialized. Did you forget them, or are they not needed? On Fri, Jul 05, 2019 at 09:57:55AM -0700, Jeffrey Hugo wrote: > The Sharp LD-D5116Z01B is a 12.3" eDP panel with a 1920X1280 resolution. > > Signed-off-by: Jeffrey Hugo > --- > drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 5a93c4edf1e4..e6f578667324 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -2354,6 +2354,29 @@ static const struct panel_desc samsung_ltn140at29_301 = { > }, > }; > > +static const struct drm_display_mode sharp_ld_d5116z01b_mode = { > + .clock = 168480, > + .hdisplay = 1920, > + .hsync_start = 1920 + 48, > + .hsync_end = 1920 + 48 + 32, > + .htotal = 1920 + 48 + 32 + 80, > + .vdisplay = 1280, > + .vsync_start = 1280 + 3, > + .vsync_end = 1280 + 3 + 10, > + .vtotal = 1280 + 3 + 10 + 57, > + .vrefresh = 60, > +}; No .flags? Is it not needed for an eDP panel? > + > +static const struct panel_desc sharp_ld_d5116z01b = { > + .modes = &sharp_ld_d5116z01b_mode, > + .num_modes = 1, > + .bpc = 8, > + .size = { > + .width = 260, > + .height = 120, > + }, > +}; No .bus_format? No .bus_flags? Sam