Re: [PATCH] drm/msm/a6xx: add missing MODULE_FIRMWARE()

Rob Clark
2019-07-10T16:05:22Z

On Mon, Jul 8, 2019 at 11:18 AM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> On Wed 03 Jul 07:00 PDT 2019, Rob Clark wrote:
>
> > From: Rob Clark <robdclark@chromium.org>
> >
> > For platforms that require the "zap shader" to take the GPU out of
> > secure mode at boot, we also need the zap fw to end up in the initrd.
> >
> > Signed-off-by: Rob Clark <robdclark@chromium.org>
>
> My upcoming pull request for this merge window includes the support for
> the mdt_loader to read unsplit firmware files. So how about running the
> firmware through [1] (pil-squasher a630_zap.mbn a630_zap.mdt) and
> pointing the driver to use the single .mbn file instead?
>

I wonder if it would just make sense to list both, at least until we
change the a6xx code to *require* zap fw if the zap node in dt isn't
removed (since the outcome of gpu driver assuming missing zap fw means
zap is not required is slightly brutal)

BR,
-R

>
> If not, you have my:
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> [1] https://github.com/andersson/pil-squasher
>