From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAFB0C76191 for ; Mon, 15 Jul 2019 22:44:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DF9D2080A for ; Mon, 15 Jul 2019 22:44:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563230686; bh=vRJ6Yk/9Jwix106bwTxs1UaEqw5UAMjMYWYOULH4nUE=; h=In-Reply-To:References:From:To:Cc:Subject:Date:List-ID:From; b=qysaUgmWI3soglTHTjZy8qEUaM75O9YiJkAtWNxcHJPqNzTfPAXaC1Teqh26cFSKn QAX/tGViTfY7XAsX78KUH+vtuZSEfyLyeVOlt3YNT/XqJIyryJswHSN1xLJFl1ynfr ZqleETl2wYTTCyXAHvOAdVk6j981ti59in7S7NhI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731925AbfGOWon (ORCPT ); Mon, 15 Jul 2019 18:44:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:47134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731225AbfGOWon (ORCPT ); Mon, 15 Jul 2019 18:44:43 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F12122080A; Mon, 15 Jul 2019 22:44:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563230682; bh=vRJ6Yk/9Jwix106bwTxs1UaEqw5UAMjMYWYOULH4nUE=; h=In-Reply-To:References:From:To:Cc:Subject:Date:From; b=bzFYVhVZOKKep/6iOszimP/qX7BX0s5XZr0TUj7wx0SrjvWzvEQfJNPkO9rNl8w29 0VjWI9GfO0fFsQqO9kRR+akSpLMHbaDjAeX0fGlKPYXLVEVD21BEmZmWu+CTJ2T9Gh HN1fzr1rXHkb9Z4ZGbMS2JPI8B407WQehWRMj1oU= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <1557339895-21952-1-git-send-email-tdas@codeaurora.org> <1557339895-21952-4-git-send-email-tdas@codeaurora.org> <155742286525.14659.18081373668341127486@swboyd.mtv.corp.google.com> <07bcd2df-a786-ea52-8566-70f484248952@codeaurora.org> <155751085370.14659.7749105088997177801@swboyd.mtv.corp.google.com> From: Stephen Boyd To: Michael Turquette , Taniya Das Cc: Andy Gross , David Brown , Rajendra Nayak , linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/3] clk: qcom: rcg: update the DFS macro for RCG User-Agent: alot/0.8.1 Date: Mon, 15 Jul 2019 15:44:41 -0700 Message-Id: <20190715224441.F12122080A@mail.kernel.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Taniya Das (2019-05-12 20:44:46) > On 5/10/2019 11:24 PM, Stephen Boyd wrote: > >>>> diff --git a/drivers/clk/qcom/clk-rcg.h b/drivers/clk/qcom/clk-rcg.h > >>>> index 5562f38..e40e8f8 100644 > >>>> --- a/drivers/clk/qcom/clk-rcg.h > >>>> +++ b/drivers/clk/qcom/clk-rcg.h > >>>> @@ -171,7 +171,7 @@ struct clk_rcg_dfs_data { > >>>> }; > >>>> > >>>> #define DEFINE_RCG_DFS(r) \ > >>>> - { .rcg =3D &r##_src, .init =3D &r##_init } > >>>> + { .rcg =3D &r, .init =3D &r##_init } > >>> > >>> Why do we need to rename the init data? > >>> > >> > >> We want to manage the init data as the clock source name, so that we > >> could manage to auto generate our code. So that we do not have to > >> re-name the clock init data manually if the DFS source names gets > >> updated at any point of time. > >> > >=20 > > Why is the clk name changing to not have a _src after the "root" of the > > clk name? As long as I can remember, RCGs have a "_src" postfix. > >=20 >=20 > Yes, the RCGs would have _src, so we do want the init data also to be > generated with _src postfix. So that we do not have to manually clean up = > the generated code. >=20 Please manually cleanup the generated code, or fix the code generator to do what you want.