From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 996E6C433FF for ; Mon, 5 Aug 2019 22:41:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BD88216B7 for ; Mon, 5 Aug 2019 22:41:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yIptHBFK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730457AbfHEWlQ (ORCPT ); Mon, 5 Aug 2019 18:41:16 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:44967 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728483AbfHEWlQ (ORCPT ); Mon, 5 Aug 2019 18:41:16 -0400 Received: by mail-pg1-f196.google.com with SMTP id i18so40459494pgl.11 for ; Mon, 05 Aug 2019 15:41:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=GWbcR3xvFDNmBGhYbznH6s7cLBaKp4a0/ddWesxNcF8=; b=yIptHBFKiXtoJSpxG3bR7btwflHxC+u7tsW/YMVsilyZv3CTs+hJ3/PAxxja3yprwN K2/s/xCu4j+TWNoXy/J6zSUNZAocXBZ1mR4kh0psZKMbQ2lX1CQgghFFQBAegs65elzk VqLFyHVt/3zuzmKlOHgufofFKYe0yx0kj9YJGhq/pA1qRoo7gdfKltcISoR17nHf+j5i hyAkAlGYhIiubvjjO37w2cwMfYzNcTgDzChUGsK7ckYLT8fJCsnIv7HVEYD0C/VHdWS+ CeTU3VVek8p8cm9q6Px8AcLxRA0Lw7yu7tMcmQFN8wcxAT4VdpzZe70ltRJHwtskyk2b tLHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GWbcR3xvFDNmBGhYbznH6s7cLBaKp4a0/ddWesxNcF8=; b=B0h6eM5IkZulbjgYNs/0Xy6W2Y4AzYF8JP1IYwxDpkTTlJWaY/HO9wtJ4aoEUBw6E7 KKewvnWsAtsDnZa8aN8hU7qtf4Grgk0CwFEqhlQYLycNr3fmIrbMe00bdFVXv4w0+/NC VR7DsvcIu941wGLHXGW5xxUMruGies5g8RXq5amltm/4tvpX+vUtOBZK87CzflB+Nyu/ bZ1WJEKDDCPce4UdRiZBNrAZlM92lRIkipGgQnhYz4G9Mntmxmbb4OYr/s3rituEmY8M Hg7FLumTTE543eiFBq5LXNNMtNTZHnxvnoB4DsQzMARjj+JkaGKBsfJCVZpdGkuO95Bl hFZw== X-Gm-Message-State: APjAAAWcfp1q58sHxvTNUYPMMT1e/gyLk5elM85WlJETl4Qf5XUQdi+H HJkVsJ4OSpYdXnBi8K3US5/TVQ== X-Google-Smtp-Source: APXvYqzLFSHj9hIrglUjQkYpFeaYOh80cYaOP+fMjZebJjv9jSvgLHClQzlfLnbBTszfX7Ribw6fZg== X-Received: by 2002:a65:4b8b:: with SMTP id t11mr196402pgq.130.1565044875625; Mon, 05 Aug 2019 15:41:15 -0700 (PDT) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id w22sm90250322pfi.175.2019.08.05.15.41.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Aug 2019 15:41:14 -0700 (PDT) Date: Mon, 5 Aug 2019 15:41:12 -0700 From: Bjorn Andersson To: Brian Masney Cc: agross@kernel.org, robdclark@gmail.com, sean@poorly.run, robh+dt@kernel.org, airlied@linux.ie, daniel@ffwll.ch, mark.rutland@arm.com, jonathan@marek.ca, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, jcrouse@codeaurora.org Subject: Re: [PATCH v4 5/6] soc: qcom: add OCMEM driver Message-ID: <20190805224112.GA6470@builder> References: <20190803142026.9647-1-masneyb@onstation.org> <20190803142026.9647-6-masneyb@onstation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190803142026.9647-6-masneyb@onstation.org> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sat 03 Aug 07:20 PDT 2019, Brian Masney wrote: > diff --git a/drivers/soc/qcom/ocmem.c b/drivers/soc/qcom/ocmem.c > new file mode 100644 > index 000000000000..7c28ad3108a6 > --- /dev/null > +++ b/drivers/soc/qcom/ocmem.c > @@ -0,0 +1,433 @@ > +// SPDX-License-Identifier: GPL-2.0-only [..] > +MODULE_LICENSE("GPL"); Shouldn't this be "GPL v2"? Apart from that I think this looks good. Reviewed-by: Bjorn Andersson @Rob, would you like to take this series through your tree or would you lend me an Ack on the adreno patch and I'll apply it through the qcom tree? Feel free to add my Acked-by to the relevant patches, if needed. Regards, Bjorn