From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 556E4C0650F for ; Sun, 11 Aug 2019 19:00:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 269D2208C2 for ; Sun, 11 Aug 2019 19:00:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NKH6a5rK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726053AbfHKTAX (ORCPT ); Sun, 11 Aug 2019 15:00:23 -0400 Received: from mail-pl1-f196.google.com ([209.85.214.196]:45520 "EHLO mail-pl1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725900AbfHKTAX (ORCPT ); Sun, 11 Aug 2019 15:00:23 -0400 Received: by mail-pl1-f196.google.com with SMTP id y8so4924604plr.12 for ; Sun, 11 Aug 2019 12:00:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=g4HRffWR5sTfOdPb8n2H2gBlNEK3O7QkgVCtkSjBUGc=; b=NKH6a5rKubvrnRjIiAagMdwN7DNFvpDIxEUxLYf+kcaaRrXUD4LXVeEaPzEwnv51Qn 7QZtgmEqhK5E4pjO/rrk1i6VlM2ljoxMczTY2s0GmrCxGCEIRTRvwfm2eZyvt5gl2ail i4BetvPir8rZaPCg6FdYaMlO7QhhsOWiFl05YooTM8FK+qi+aGZytl2RfGMDZccqWYcH c7A1ri271xLpFxZkPBYu7DbHUIaK8beRCewn28rCUTsX9GjAB64fyF3nlcG1issWWlne M1MeftR3HX7ZBV69FKtlbTP5HTcIxgTIQFwFvS9sWY9tl+c2q40uABiEoYtg7El1O0aC FcCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=g4HRffWR5sTfOdPb8n2H2gBlNEK3O7QkgVCtkSjBUGc=; b=ifl0gHFvGEMpZddEIHETwxlrpo81KvyDaqhTwve+HjAogfm/U02aklBz7AtQQK8mOj scIdxAbEk//2O0P4zeD5lexOSjA3DjLek1a7VM9jkcbzhHk1f4QACNc11Us+lY42ozNt onbPUMsYOKVRpNYtalGer3ooLwFQd6iId4dPEioeYPmh4I99cYgooxSfVo8zJC57kym9 kiqe+Ivekc0hVirFMyzSGnJYoOEGgFoDoy0MPqv+R7dD1anZCVEPQ8ENDgZQnV/p+rpq snTAPmrv4YHBbN1eMlj+TZ0tioxniyYfNfrBx36mV2kbCL2BSEdnlJsPM9r5EpQCDaXl vC+Q== X-Gm-Message-State: APjAAAXyHf4BxCL3UWwClEQ+mu5Hyu4yrTANyvzFODnZo2IAqwJzZGD0 6mb4bCHm7meMFG2XzBaGCVy9nA== X-Google-Smtp-Source: APXvYqzc4Bn9ATOCQYg7LsJf9jLHX1jrV/wEcEKA0Dzyd51K6OZ8vz1CVcwhFwEFMJTVX7DrRrXbdA== X-Received: by 2002:a17:902:e4:: with SMTP id a91mr29498761pla.150.1565550022586; Sun, 11 Aug 2019 12:00:22 -0700 (PDT) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id 5sm41932620pgh.93.2019.08.11.12.00.21 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Sun, 11 Aug 2019 12:00:21 -0700 (PDT) Date: Sun, 11 Aug 2019 12:01:59 -0700 From: Bjorn Andersson To: Vivek Gautam Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , Will Deacon , open list , robh+dt , David Brown , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Andy Gross , Robin Murphy Subject: Re: [PATCH v3 4/4] arm64: dts/sdm845: Enable FW implemented safe sequence handler on MTP Message-ID: <20190811190159.GQ26807@tuxbook-pro> References: <20190612071554.13573-1-vivek.gautam@codeaurora.org> <20190612071554.13573-5-vivek.gautam@codeaurora.org> <20190805222627.GA2634@builder> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sun 11 Aug 09:08 PDT 2019, Vivek Gautam wrote: > On Tue, Aug 6, 2019 at 3:56 AM Bjorn Andersson > wrote: > > > > On Wed 12 Jun 00:15 PDT 2019, Vivek Gautam wrote: > > > > > Indicate on MTP SDM845 that firmware implements handler to > > > TLB invalidate erratum SCM call where SAFE sequence is toggled > > > to achieve optimum performance on real-time clients, such as > > > display and camera. > > > > > > Signed-off-by: Vivek Gautam > > > --- > > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > > > index 78ec373a2b18..6a73d9744a71 100644 > > > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > > > @@ -2368,6 +2368,7 @@ > > > compatible = "qcom,sdm845-smmu-500", "arm,mmu-500"; > > > reg = <0 0x15000000 0 0x80000>; > > > #iommu-cells = <2>; > > > + qcom,smmu-500-fw-impl-safe-errata; > > > > Looked back at this series and started to wonder if there there is a > > case where this should not be set? I mean we're after all adding this to > > the top 845 dtsi... > > My bad. > This is not valid in case of cheza. Cheza firmware doesn't implement > the safe errata handling hook. > On cheza we just have the liberty of accessing the secure registers > through scm calls - this is what > we were doing in earlier patch series handling this errata. > So, a property like this should go to mtp board's dts file. > It would have been nice if the common case was just selected by default, but afaict no safe workaround is needed on Cheza? You mention here that it should (could?) use the scm write based approach instead, would an introduction of that come with another flag? PS. In it's current form it's correct that this should be moved to the device dts files - all but one of them... Regards, Bjorn