Re: [PATCH -next 25/36] spi: s3c24xx: use devm_platform_ioremap_resource() to simplify code

Krzysztof Kozlowski
2019-09-04T14:28:44Z

On Wed, 4 Sep 2019 at 16:00, YueHaibing <yuehaibing@huawei.com> wrote:
>
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>

This tag does not look real... First of all where is the report?
Second, it was reported by coccinelle.
Reported-by should be use to give real credits.

Best regards,
Krzysztof

> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/spi/spi-s3c24xx.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-s3c24xx.c b/drivers/spi/spi-s3c24xx.c
> index aea8fd9..2d6e37f 100644
> --- a/drivers/spi/spi-s3c24xx.c
> +++ b/drivers/spi/spi-s3c24xx.c
> @@ -487,7 +487,6 @@ static int s3c24xx_spi_probe(struct platform_device *pdev)
> struct s3c2410_spi_info *pdata;
> struct s3c24xx_spi *hw;
> struct spi_master *master;
> - struct resource *res;
> int err = 0;
>
> master = spi_alloc_master(&pdev->dev, sizeof(struct s3c24xx_spi));
> @@ -536,8 +535,7 @@ static int s3c24xx_spi_probe(struct platform_device *pdev)
> dev_dbg(hw->dev, "bitbang at %p\n", &hw->bitbang);
>
> /* find and map our resources */
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - hw->regs = devm_ioremap_resource(&pdev->dev, res);
> + hw->regs = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(hw->regs)) {
> err = PTR_ERR(hw->regs);
> goto err_no_pdata;
> --
> 2.7.4
>
>