From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7914CC3A5A5 for ; Thu, 5 Sep 2019 11:13:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B88522CF5 for ; Thu, 5 Sep 2019 11:13:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CMd3yrld" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732130AbfIELN6 (ORCPT ); Thu, 5 Sep 2019 07:13:58 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:42569 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731124AbfIELN6 (ORCPT ); Thu, 5 Sep 2019 07:13:58 -0400 Received: by mail-lj1-f196.google.com with SMTP id y23so2009828lje.9 for ; Thu, 05 Sep 2019 04:13:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hVb3OF8Z1yUcAp1EC0wGieEJY1VYhAGYv9dxmBhAdNQ=; b=CMd3yrldzyge7k1rGSlqrfxb2zyzXCZwifzGp2sdva/Ug31rtuPMdg/1TiF5qOiVuL PA01RD4IEPI00S+jUUCtOPABJ1+BBQeQAbNm5pFqEv9b57m4v/RIiB+DAsniDmQNBiZI ezvZ4uJu8v+gvFA2/nQYV0T6uTETR7SknY13uZq7IOFbqBNzlb+XSH/ZAQLDP7NEOozI LfM5E3yXJTmpz7scocKK4yBK6Ekk7R/DJzUUqBlwQKPeyStYzvudfR2t7H7M8iaPW53K SbTtOB0rH2F44WrKIzvL0t5JPZo2VOKaoT7sLKZpb7FNJ6tkqmI6JfnRPsXU3ON9XheT XRgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hVb3OF8Z1yUcAp1EC0wGieEJY1VYhAGYv9dxmBhAdNQ=; b=idGbBZObAuhD29/qkK9pc/7C9DMBbRvgKmFSgI8TS6BoRii4eRI6LkSUSLLZ8GJNH2 CEfNHC2NvRYsLI4uBtF7QLkGidFF9EfVElvNchSTd4E8DDXcK4ybhpfHpoOYLGhhSrCM iKWq55OXO7oHJpoLZ4ad2/o/Ik3FO7bKhhPm6G/SvR+l2TqbXtxLFILHadyIUYqz5kry G1PqGaqnI9tpIlGrClejjO0eFi2y4+4HXC+yha6J1YM6E5psTvwuE1+uE2/Vgn/OuChu m63Mu4/pSu5ZjSM1vw0FxLLuGvjJ8/4F/8aF4hvOWQuZxb2bD9/gXRJk0kWWYFHnIYZU rCjg== X-Gm-Message-State: APjAAAXOY3jEXwsV5HP3osTgE7GUzfJtjLrEysF2XHm/ogNcf06xEHHD VwbD50z5JjNvxXXzE0mkUGYQag== X-Google-Smtp-Source: APXvYqzhi25MQJx4FepzPT+vyEF5/SUZT0BCOG1lmKkN8q2WaXy7ytL75H31vK5Qawvs8R3VY1Qz0A== X-Received: by 2002:a2e:90c6:: with SMTP id o6mr1700683ljg.144.1567682036461; Thu, 05 Sep 2019 04:13:56 -0700 (PDT) Received: from centauri (ua-84-219-138-247.bbcust.telenor.se. [84.219.138.247]) by smtp.gmail.com with ESMTPSA id m18sm379548lfb.73.2019.09.05.04.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2019 04:13:55 -0700 (PDT) Date: Thu, 5 Sep 2019 13:13:53 +0200 From: Niklas Cassel To: Bjorn Andersson Cc: Ohad Ben-Cohen , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: Re: [PATCH] rpmsg: glink-smem: Name the edge based on parent remoteproc Message-ID: <20190905111353.GA1936@centauri> References: <20190820041656.17197-1-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190820041656.17197-1-bjorn.andersson@linaro.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Aug 19, 2019 at 09:16:56PM -0700, Bjorn Andersson wrote: > Naming the glink edge device on the parent of_node short name causes > collisions when multiple remoteproc instances with only different unit > address are described on the platform_bus in DeviceTree. > > Base the edge's name on the parent remoteproc's name instead, to ensure > that it's unique. > > Signed-off-by: Bjorn Andersson > --- > drivers/rpmsg/qcom_glink_smem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rpmsg/qcom_glink_smem.c b/drivers/rpmsg/qcom_glink_smem.c > index 64a5ce324c7f..4238383d8685 100644 > --- a/drivers/rpmsg/qcom_glink_smem.c > +++ b/drivers/rpmsg/qcom_glink_smem.c > @@ -201,7 +201,7 @@ struct qcom_glink *qcom_glink_smem_register(struct device *parent, > dev->parent = parent; > dev->of_node = node; > dev->release = qcom_glink_smem_release; > - dev_set_name(dev, "%pOFn:%pOFn", node->parent, node); > + dev_set_name(dev, "%s:%pOFn", dev_name(parent->parent), node); > ret = device_register(dev); > if (ret) { > pr_err("failed to register glink edge\n"); > -- > 2.18.0 > This was sent 19 of August, then again (unchanged) on 29 of August. Yet it is still not in linux-next. It fixes a real issue on qcs404, so please merge :) Kind regards, Niklas