From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85A3FC3A5A5 for ; Thu, 5 Sep 2019 13:15:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 40A752067D for ; Thu, 5 Sep 2019 13:15:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="b+63NMLi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388424AbfIENPB (ORCPT ); Thu, 5 Sep 2019 09:15:01 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:43256 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733010AbfIENPA (ORCPT ); Thu, 5 Sep 2019 09:15:00 -0400 Received: by mail-lf1-f67.google.com with SMTP id q27so1970351lfo.10 for ; Thu, 05 Sep 2019 06:14:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=X6liaIL8n/K+qZNHyRxBvsG3aE56VnalzfSINEJsXSQ=; b=b+63NMLiO6uu9ngd3jzIr8Dsw188HJm9sNb07rlJMnX80r7/h5LUN3/Lpbh3bxpJ9z xYJqjXXgagt+VDuvA3yKvH7qp7A2+W1iv5h1mRb24Jb2adl7EuLWgyNX1JPnrepTNa9Q goCuPYhfmvTDmiz0qWuVckEjqgfqRDoltmXHgdBIf8vad80BD+OtqWFql1CSBxLD7jDL PWs9E6CwQdu80zJAOHSJX+PJNszKu0Zwaywda1OI5fC9bc/t0il8d+aa4SI03VA65BG0 pqsIykPn5ko3cJwLwAXbf0ErZ98Dsu+DqnGqOb8fcfaBo5zLC2Uk4FyM9xYDgLnBUVyl HiPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=X6liaIL8n/K+qZNHyRxBvsG3aE56VnalzfSINEJsXSQ=; b=PvBLG8wFXGTGt/Ld3hqyW++Vw/lzzNPdv8YfnoL+ZwYprqZ6vLVvZzkHTgVEkaKema BEXptx4VHLvoZhjh8C5twnlhQQW4KqU4qx+v8ODCxGx2xD2tbqp28UDoYwheS1hu20L1 NjErso5UW4b2P0NVTlsjNkxhuItn4Akqfl4eKeexDKhV7gZqzIl5xvHAva6OFGZuyK/N H46ynaXFUTYpkyPmiplR5czcAxwfsMnWRead9NIxEL/jLVeff8dAIhr+/gMCj5WZxvyF KkZTR18TDQ5XuCxJDbiTamHEQ2hrqoSFv12D5QguIMoJ71pUCWQzG112l0Xs9R83rsdT 0oPA== X-Gm-Message-State: APjAAAU6TDmTa08PLfwmUSCfIy+dOdBCba7bdJPiDFy1sRbwyFLQVG4i USE0ceenzccclFrojEM0ffdELA== X-Google-Smtp-Source: APXvYqzbCMnjO//eiTEa0kZuQw26H3btOjLN9fQPzx/MdOvkhMnN7oM0V3sFQZMv6aa2tmtB3chimQ== X-Received: by 2002:a19:4912:: with SMTP id w18mr2283793lfa.93.1567689298714; Thu, 05 Sep 2019 06:14:58 -0700 (PDT) Received: from centauri (ua-84-219-138-247.bbcust.telenor.se. [84.219.138.247]) by smtp.gmail.com with ESMTPSA id b25sm486140lfa.90.2019.09.05.06.14.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Sep 2019 06:14:58 -0700 (PDT) Date: Thu, 5 Sep 2019 15:14:56 +0200 From: Niklas Cassel To: Bjorn Andersson Cc: Ohad Ben-Cohen , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Kandagatla Subject: Re: [PATCH] rpmsg: glink-smem: Name the edge based on parent remoteproc Message-ID: <20190905131456.GA26674@centauri> References: <20190820041656.17197-1-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190820041656.17197-1-bjorn.andersson@linaro.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Aug 19, 2019 at 09:16:56PM -0700, Bjorn Andersson wrote: > Naming the glink edge device on the parent of_node short name causes > collisions when multiple remoteproc instances with only different unit > address are described on the platform_bus in DeviceTree. > > Base the edge's name on the parent remoteproc's name instead, to ensure > that it's unique. > > Signed-off-by: Bjorn Andersson > --- > drivers/rpmsg/qcom_glink_smem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rpmsg/qcom_glink_smem.c b/drivers/rpmsg/qcom_glink_smem.c > index 64a5ce324c7f..4238383d8685 100644 > --- a/drivers/rpmsg/qcom_glink_smem.c > +++ b/drivers/rpmsg/qcom_glink_smem.c > @@ -201,7 +201,7 @@ struct qcom_glink *qcom_glink_smem_register(struct device *parent, > dev->parent = parent; > dev->of_node = node; > dev->release = qcom_glink_smem_release; > - dev_set_name(dev, "%pOFn:%pOFn", node->parent, node); > + dev_set_name(dev, "%s:%pOFn", dev_name(parent->parent), node); > ret = device_register(dev); > if (ret) { > pr_err("failed to register glink edge\n"); > -- > 2.18.0 > Reviewed-by: Niklas Cassel