Re: [PATCH v1 1/3] dt-bindings: clock: Add YAML schemas for the QCOM RPMHCC clock bindings

Rob Herring
2019-10-29T02:04:57Z

On Fri, Oct 18, 2019 at 03:39:22PM +0530, Taniya Das wrote:
> The RPMHCC clock provider have a bunch of generic properties that
> are needed in a device tree. Add a YAML schemas for those.
>
> Signed-off-by: Taniya Das <tdas@codeaurora.org>
> ---
> .../devicetree/bindings/clock/qcom,rpmh-clk.txt | 27 ------------
> .../devicetree/bindings/clock/qcom,rpmhcc.yaml | 49 ++++++++++++++++++++++
> 2 files changed, 49 insertions(+), 27 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt
> create mode 100644 Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt b/Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt
> deleted file mode 100644
> index 365bbde..0000000
> --- a/Documentation/devicetree/bindings/clock/qcom,rpmh-clk.txt
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -Qualcomm Technologies, Inc. RPMh Clocks
> --------------------------------------------------------
> -
> -Resource Power Manager Hardened (RPMh) manages shared resources on
> -some Qualcomm Technologies Inc. SoCs. It accepts clock requests from
> -other hardware subsystems via RSC to control clocks.
> -
> -Required properties :
> -- compatible : must be one of:
> - "qcom,sdm845-rpmh-clk"
> - "qcom,sm8150-rpmh-clk"
> -
> -- #clock-cells : must contain 1
> -- clocks: a list of phandles and clock-specifier pairs,
> - one for each entry in clock-names.
> -- clock-names: Parent board clock: "xo".
> -
> -Example :
> -
> -#include <dt-bindings/clock/qcom,rpmh.h>
> -
> - &apps_rsc {
> - rpmhcc: clock-controller {
> - compatible = "qcom,sdm845-rpmh-clk";
> - #clock-cells = <1>;
> - };
> - };
> diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml b/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml
> new file mode 100644
> index 0000000..326bfd7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bindings/clock/qcom,rpmhcc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies, Inc. RPMh Clocks Bindings
> +
> +maintainers:
> + - Taniya Das <tdas@codeaurora.org>
> +
> +description: |
> + Resource Power Manager Hardened (RPMh) manages shared resources on
> + some Qualcomm Technologies Inc. SoCs. It accepts clock requests from
> + other hardware subsystems via RSC to control clocks.
> +
> +properties:
> + compatible :

drop space ^

> + enum:
> + - qcom,sdm845-rpmh-clk
> + - qcom,sm8150-rpmh-clk

Wrong indent (1 char too many).

> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + maxItems: 1

Can drop this. Implied by items list.

> + items:
> + - const: xo
> +
> + '#clock-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - '#clock-cells'
> +
> +examples:
> + # Example for GCC for SDM845: The below node should be defined inside
> + # &apps_rsc node.
> + - |
> + #include <dt-bindings/clock/qcom,rpmh.h>
> + rpmhcc: clock-controller {
> + compatible = "qcom,sdm845-rpmh-clk";
> + clocks = <&xo_board>;
> + clock-names = "xo";
> + #clock-cells = <1>;
> + };
> +...
> --
> Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
> of the Code Aurora Forum, hosted by the Linux Foundation.
>