From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D64A3CA9ECF for ; Mon, 4 Nov 2019 07:10:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A62FE2246B for ; Mon, 4 Nov 2019 07:10:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rvIq103d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726891AbfKDHKc (ORCPT ); Mon, 4 Nov 2019 02:10:32 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:44300 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726248AbfKDHKb (ORCPT ); Mon, 4 Nov 2019 02:10:31 -0500 Received: by mail-pg1-f195.google.com with SMTP id f19so1563173pgk.11 for ; Sun, 03 Nov 2019 23:10:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=t4TV25A1uMzOUpxnPE9T6D69bjxp+CQFn1rWNaSp17E=; b=rvIq103d5QvkQPhePPHFLq0nK/ACbSKZY7eteyZPRm6ZQLdn2P9/L9r/QTnrN6rUNP jm/ua7SGVaxRhSR5Nl9cOL5W9VLF8VkSl68eghceC1CCxqeyfDFNFUNDf85yimIPPvY0 o1yfdXK5tO1vLx1FxzcPkmng+u9IkRYuIwq5EzIIzZ68U8SNrPlIZsU7d0qY1AO6zsuI pS1eCuVH8jlep136XfWsjFnO9FVNrx6OLJT5MeeAZHVVLtbzerSB2XgwPwUxJ+miWDfv 02MGnva9fIZ+K8PsBCyhgUeisAMN55iFNb1AzWrJ037fxdbVJklLbH3Lgnji2xW2YZRp 2V9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=t4TV25A1uMzOUpxnPE9T6D69bjxp+CQFn1rWNaSp17E=; b=Xr2yEOBEi73KmHm6uaUGzyxOlSt70EMbXlBtPUVjf/hoPDr3Z2YVnpflNTOWInrcjf Z5asbnO9df5oi+Wyz8wIl09MLFGTAm/mha6bgt6mFfoyWMh8/G6ErKITIds0BkYT3Brt gTlGgwK9GEKusP5y1nBhPQrFH+dxcQZshmTLfOawMpqp/Vl5aJcAKSkARQWnkLEI3oh2 Rb/hea//I93KMZaiegikPVsVmHPJ0RQwCXtrura/TFvYTGxkeAk4WBEtCkcoUaYBIWp1 lmMrmG3XfoVx90jW7PZHyPHoXCT1tp6QRwRaT/I/FTC2//QZZAFw31UUe035vEvLM4BW uEuw== X-Gm-Message-State: APjAAAUa3snVkSHY+FZPUpmgBNiPUUsRrUiaUWRBJDtt5LxVyD1jWpIy a8sEHx42oXeqQdoAYY4qt2CVtw== X-Google-Smtp-Source: APXvYqxHOP7JBpbRrN/9vm7qE7CKnT+oDstfysttIvzcmp2Ai7mrtOlTLr+klYFNg71UF1Ve/+0Xhg== X-Received: by 2002:a63:b62:: with SMTP id a34mr8305598pgl.123.1572851430833; Sun, 03 Nov 2019 23:10:30 -0800 (PST) Received: from tuxbook-pro (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id l11sm16775340pgr.77.2019.11.03.23.10.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Nov 2019 23:10:30 -0800 (PST) Date: Sun, 3 Nov 2019 23:10:27 -0800 From: Bjorn Andersson To: Rajendra Nayak Cc: Matthias Kaehlcke , Stephen Boyd , agross@kernel.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Maulik Shah Subject: Re: [PATCH v3 11/11] arm64: dts: qcom: sc7180: Add pdc interrupt controller Message-ID: <20191104071027.GD585@tuxbook-pro> References: <20191023090219.15603-1-rnayak@codeaurora.org> <20191023090219.15603-12-rnayak@codeaurora.org> <5db86de0.1c69fb81.9e27d.0f47@mx.google.com> <20191030195021.GC27773@google.com> <6610d7fe-5a4d-5a43-5c4f-9ae61e7e53ee@codeaurora.org> <20191104063348.GA2464@tuxbook-pro> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sun 03 Nov 22:56 PST 2019, Rajendra Nayak wrote: > > > On 11/4/2019 12:03 PM, Bjorn Andersson wrote: > > On Sun 03 Nov 22:17 PST 2019, Rajendra Nayak wrote: > > > > > > > > > > > On 10/31/2019 1:20 AM, Matthias Kaehlcke wrote: > > > > On Tue, Oct 29, 2019 at 09:50:40AM -0700, Stephen Boyd wrote: > > > > > Quoting Rajendra Nayak (2019-10-23 02:02:19) > > > > > > From: Maulik Shah > > > > > > > > > > > > Add pdc interrupt controller for sc7180 > > > > > > > > > > > > Signed-off-by: Maulik Shah > > > > > > Signed-off-by: Rajendra Nayak > > > > > > --- > > > > > > v3: > > > > > > Used the qcom,sdm845-pdc compatible for pdc node > > > > > > > > > > Everything else isn't doing the weird old compatible thing. Why not just > > > > > add the new compatible and update the driver? I guess I'll have to go > > > > > read the history. > > > > > > > > Marc Zyngier complained on v2 about the churn from adding compatible > > > > strings for identical components, and I kinda see his point. > > > > > > > > I agree that using the 'sdm845' compatible string for sc7180 is odd too. > > > > Maybe we should introduce SoC independent compatible strings for IP blocks > > > > that are shared across multiple SoCs? If differentiation is needed SoC > > > > specific strings can be added. > > > > > > Sure, I will perhaps add a qcom,pdc SoC independent compatible to avoid > > > confusion. > > > > > > > I agree, > > > > compatible = "qcom,sc7180-pdc", "qcom,pdc"; > > > > is the way to go. > > I wasn't planning on adding a qcom,sc7180-pdc, but instead just use the > qcom,pdc one for sc7180. > > > > > Reusing qcom,sdm845-pdc would prevent us from tackling any unforeseen > > issues/variations/erratas with one or the other platform in the future. > > That was the intention of adding qcom,sc7180-pdc in the first place, > but Marc Zyngier was not happy with the churn, given there aren't really > any variations or erratas that we know of. > Right, but by putting both compatibles in the dts and the generic one in the driver we avoid the driver churn and we're future compatible. And given that we haven't yet added the qcom,sdm845-pdc node to the sdm845.dtsi we don't need to maintain the qcom,sdm845-pdc in the driver. So switch qcom,sdm845-pdc to qcom,pdc in qcom-pdc.c. Regards, Bjorn > > > > Regards, > > Bjorn > > > > > > > > -- > > > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > > > of Code Aurora Forum, hosted by The Linux Foundation > > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation