From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: kholk11@gmail.com
Cc: linux-arm-msm@vger.kernel.org, marijns95@gmail.com,
robdclark@gmail.com, sean@poorly.run, airlied@linux.ie,
daniel@ffwll.ch, robh+dt@kernel.org, mark.rutland@arm.com,
tglx@linutronix.de, jonathan@marek.ca, georgi.djakov@linaro.org,
gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org
Subject: Re: [PATCH v4 5/7] dt-bindings: msm/dsi: Add 28nm PLL for family B compatible
Date: Mon, 4 Nov 2019 12:42:20 -0800 [thread overview]
Message-ID: <20191104204220.GB586@tuxbook-pro> (raw)
In-Reply-To: <20191031104402.31813-6-kholk11@gmail.com>
On Thu 31 Oct 03:44 PDT 2019, kholk11@gmail.com wrote:
> From: AngeloGioacchino Del Regno <kholk11@gmail.com>
>
> On family B SoCs, the 28nm PLL has a different iospace address
> and that required a new compatible in the driver.
>
> Signed-off-by: AngeloGioacchino Del Regno <kholk11@gmail.com>
> ---
> Documentation/devicetree/bindings/display/msm/dsi.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/display/msm/dsi.txt b/Documentation/devicetree/bindings/display/msm/dsi.txt
> index af95586c898f..d3ba9ee22f38 100644
> --- a/Documentation/devicetree/bindings/display/msm/dsi.txt
> +++ b/Documentation/devicetree/bindings/display/msm/dsi.txt
> @@ -83,6 +83,7 @@ DSI PHY:
> Required properties:
> - compatible: Could be the following
> * "qcom,dsi-phy-28nm-hpm"
> + * "qcom,dsi-phy-28nm-hpm-fam-b"
Wouldn't it be preferable to use specific platform numbers here?
Regards,
Bjorn
> * "qcom,dsi-phy-28nm-lp"
> * "qcom,dsi-phy-20nm"
> * "qcom,dsi-phy-28nm-8960"
> --
> 2.21.0
>
next prev parent reply other threads:[~2019-11-04 20:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 10:43 [PATCH v4 0/7] DRM/MSM: Add support for MSM8956 and Adreno 510 kholk11
2019-10-31 10:43 ` [PATCH v4 1/7] drm/msm/mdp5: Add optional TBU and TBU_RT clocks kholk11
2019-10-31 10:43 ` [PATCH v4 2/7] dt-bindings: msm/mdp5: Document " kholk11
2019-11-02 16:53 ` Rob Clark
2019-11-04 20:16 ` Rob Herring
2019-10-31 10:43 ` [PATCH v4 3/7] drm/msm/mdp5: Add configuration for msm8x76 kholk11
2019-10-31 10:43 ` [PATCH v4 4/7] drm/msm/dsi: Add configuration for 28nm PLL on family B kholk11
2019-10-31 10:44 ` [PATCH v4 5/7] dt-bindings: msm/dsi: Add 28nm PLL for family B compatible kholk11
2019-11-02 16:54 ` Rob Clark
2019-11-04 20:18 ` Rob Herring
2019-11-04 20:42 ` Bjorn Andersson [this message]
2019-10-31 10:44 ` [PATCH v4 6/7] drm/msm/dsi: Add configuration for 8x76 kholk11
2019-10-31 10:44 ` [PATCH v4 7/7] drm/msm/adreno: Add support for Adreno 510 GPU kholk11
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104204220.GB586@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=georgi.djakov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=jonathan@marek.ca \
--cc=kholk11@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marijns95@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean@poorly.run \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox