Re: [PATCH v5 06/13] drivers: irqchip: qcom-pdc: Move to an SoC independent compatible

Marc Zyngier
2019-11-08T09:40:34Z

On 2019-11-08 10:37, Rajendra Nayak wrote:
> Remove the sdm845 SoC specific compatible to make the driver
> easily reusable across other SoC's with the same IP block.
> This will reduce further churn adding any SoC specific
> compatibles unless really needed.
>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> Reviewed-by: Lina Iyer <ilina@codeaurora.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> Cc: Marc Zyngier <maz@kernel.org>
> ---
> drivers/irqchip/qcom-pdc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
> index faa7d61b9d6c..c175333bb646 100644
> --- a/drivers/irqchip/qcom-pdc.c
> +++ b/drivers/irqchip/qcom-pdc.c
> @@ -309,4 +309,4 @@ static int qcom_pdc_init(struct device_node
> *node, struct device_node *parent)
> return ret;
> }
>
> -IRQCHIP_DECLARE(pdc_sdm845, "qcom,sdm845-pdc", qcom_pdc_init);
> +IRQCHIP_DECLARE(qcom_pdc, "qcom,pdc", qcom_pdc_init);

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

How do you want me get this (and the DT change) merged? I can either
take
these two patches in the irqchip tree, or you arrange them to be taken
by the platform maintainers. Your call.

Thanks,

M.
--
Jazz is not dead. It just smells funny...