From: Brian Masney <masneyb@onstation.org>
To: Stephen Boyd <sboyd@kernel.org>
Cc: mturquette@baylibre.com, agross@kernel.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org,
jonathan@marek.ca
Subject: Re: [PATCH] clk: qcom: mmcc8974: move gfx3d_clk_src from the mmcc to rpm
Date: Sat, 16 Nov 2019 20:41:05 -0500 [thread overview]
Message-ID: <20191117014105.GA13775@onstation.org> (raw)
In-Reply-To: <20191117012737.CED5B20730@mail.kernel.org>
On Sat, Nov 16, 2019 at 05:27:36PM -0800, Stephen Boyd wrote:
> Quoting Brian Masney (2019-11-16 10:54:57)
> > > diff --git a/drivers/clk/qcom/mmcc-msm8974.c b/drivers/clk/qcom/mmcc-msm8974.c
> > > index bcb0a397ef91..015426262d08 100644
> > > --- a/drivers/clk/qcom/mmcc-msm8974.c
> > > +++ b/drivers/clk/qcom/mmcc-msm8974.c
> > > @@ -2411,7 +2399,6 @@ static struct clk_regmap *mmcc_msm8974_clocks[] = {
> > > [VFE0_CLK_SRC] = &vfe0_clk_src.clkr,
> > > [VFE1_CLK_SRC] = &vfe1_clk_src.clkr,
> > > [MDP_CLK_SRC] = &mdp_clk_src.clkr,
> > > - [GFX3D_CLK_SRC] = &gfx3d_clk_src.clkr,
> > > [JPEG0_CLK_SRC] = &jpeg0_clk_src.clkr,
> > > [JPEG1_CLK_SRC] = &jpeg1_clk_src.clkr,
> > > [JPEG2_CLK_SRC] = &jpeg2_clk_src.clkr,
> >
> > I just realized that I also need to remove the GFX3D_CLK_SRC #define
> > from include/dt-bindings/clock/qcom,mmcc-msm8974.h. I'll send out a v2
> > tomorrow evening.
> >
>
> Please don't change the binding. In reality the define will never be
> used but also in reality the clk exists, so it's fine to leave it in the
> binding.
OK, that makes sense. Thanks for your help on this.
Brian
next prev parent reply other threads:[~2019-11-17 1:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 12:39 [PATCH] clk: qcom: mmcc8974: move gfx3d_clk_src from the mmcc to rpm Brian Masney
2019-11-16 16:51 ` Bjorn Andersson
2019-11-16 18:54 ` Brian Masney
2019-11-17 1:27 ` Stephen Boyd
2019-11-17 1:41 ` Brian Masney [this message]
2019-12-19 5:28 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191117014105.GA13775@onstation.org \
--to=masneyb@onstation.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox