From: Vinod Koul <vkoul@kernel.org>
To: Mathias Nyman <mathias.nyman@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: John Stultz <john.stultz@linaro.org>,
Mathias Nyman <mathias.nyman@intel.com>,
linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Christian Lamparter <chunkeey@googlemail.com>,
linux-usb@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Todd Kjos <tkjos@google.com>, Alistair Delva <adelva@google.com>
Subject: Re: [PATCH v5 0/4] usb: xhci: Add support for Renesas USB controllers
Date: Thu, 9 Jan 2020 17:39:05 +0530 [thread overview]
Message-ID: <20200109120905.GV2818@vkoul-mobl> (raw)
In-Reply-To: <20200108182907.GB2549996@kroah.com>
On 08-01-20, 19:29, Greg Kroah-Hartman wrote:
> On Wed, Jan 08, 2020 at 06:00:48PM +0200, Mathias Nyman wrote:
> >
> > Reviewing this always got bumped down on my todo list as other urgent issues
> > came up.
> >
> > I think the concern about adding this amount of renesas specific code to
> > xhci-pci.c is valid. This series adds over 900 lines of Renesas FW loading
> > code to a 600 line xhci-pci.c
>
> Yeah, that's not good, should be simple to split it into a separate file
> that's only build if that hardware is selected.
Okay let me redo the patches splitting it up. If you have any thoughts
about how that should be done, do let me know.
Thanks
--
~Vinod
prev parent reply other threads:[~2020-01-09 12:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 8:38 [PATCH v5 0/4] usb: xhci: Add support for Renesas USB controllers Vinod Koul
2019-11-06 8:38 ` [PATCH v5 1/4] usb: xhci: add firmware loader for uPD720201 and uPD720202 w/o ROM Vinod Koul
2019-11-06 8:38 ` [PATCH v5 2/4] usb: xhci: Add ROM loader for uPD720201 Vinod Koul
2019-11-06 8:38 ` [PATCH v5 3/4] usb: xhci: allow multiple firmware versions Vinod Koul
2019-11-06 8:38 ` [PATCH v5 4/4] usb: xhci: provide a debugfs hook for erasing rom Vinod Koul
2019-11-21 4:54 ` [PATCH v5 0/4] usb: xhci: Add support for Renesas USB controllers Vinod Koul
2019-11-26 15:59 ` Mathias Nyman
2019-12-06 4:21 ` Vinod Koul
2020-01-07 19:51 ` John Stultz
2020-01-08 4:07 ` Vinod Koul
2020-01-08 6:24 ` Greg Kroah-Hartman
2020-01-08 16:00 ` Mathias Nyman
2020-01-08 18:29 ` Greg Kroah-Hartman
2020-01-09 12:09 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109120905.GV2818@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=adelva@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=chunkeey@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=tkjos@google.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox