From: kbuild test robot <lkp@intel.com>
To: Shaik Sajida Bhanu <sbhanu@codeaurora.org>
Cc: kbuild-all@lists.01.org, ulf.hansson@linaro.org,
adrian.hunter@intel.com, asutoshd@codeaurora.org,
stummala@codeaurora.org, vbadigan@codeaurora.org,
sayalil@codeaurora.org, cang@codeaurora.org,
rampraka@codeaurora.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
agross@kernel.org, bjorn.andersson@linaro.org,
Shaik Sajida Bhanu <sbhanu@codeaurora.org>
Subject: Re: [PATCH V1] mmc: sdhci-msm: Add system suspend/resume callbacks
Date: Sat, 25 Jan 2020 23:28:05 +0800 [thread overview]
Message-ID: <202001251815.E5Q9CSnW%lkp@intel.com> (raw)
In-Reply-To: <1579617022-13031-1-git-send-email-sbhanu@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 3275 bytes --]
Hi Shaik,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to ulf.hansson-mmc/next mmc/mmc-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Shaik-Sajida-Bhanu/mmc-sdhci-msm-Add-system-suspend-resume-callbacks/20200124-084227
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 34597c85be987cc731a840fa0c9bb969c92bd986
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/mmc/host/sdhci-msm.c: In function 'sdhci_msm_suspend':
>> drivers/mmc/host/sdhci-msm.c:2043:9: error: implicit declaration of function 'cqhci_suspend'; did you mean 'cpu_do_suspend'? [-Werror=implicit-function-declaration]
ret = cqhci_suspend(host->mmc);
^~~~~~~~~~~~~
cpu_do_suspend
drivers/mmc/host/sdhci-msm.c: In function 'sdhci_msm_resume':
>> drivers/mmc/host/sdhci-msm.c:2073:9: error: implicit declaration of function 'cqhci_resume'; did you mean 'sdhci_reset'? [-Werror=implicit-function-declaration]
ret = cqhci_resume(host->mmc);
^~~~~~~~~~~~
sdhci_reset
cc1: some warnings being treated as errors
vim +2043 drivers/mmc/host/sdhci-msm.c
2034
2035 static int sdhci_msm_suspend(struct device *dev)
2036 {
2037 struct sdhci_host *host = dev_get_drvdata(dev);
2038 struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
2039 struct sdhci_msm_host *msm_host = sdhci_pltfm_priv(pltfm_host);
2040 int ret = 0;
2041
2042 if (host->mmc->caps2 & MMC_CAP2_CQE) {
> 2043 ret = cqhci_suspend(host->mmc);
2044 if (ret)
2045 return ret;
2046 }
2047
2048 disable_irq(msm_host->pwr_irq);
2049 ret = sdhci_suspend_host(host);
2050 if (ret)
2051 return ret;
2052
2053 return sdhci_msm_runtime_suspend(dev);
2054 }
2055
2056 static int sdhci_msm_resume(struct device *dev)
2057 {
2058 struct sdhci_host *host = dev_get_drvdata(dev);
2059 struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
2060 struct sdhci_msm_host *msm_host = sdhci_pltfm_priv(pltfm_host);
2061 int ret = 0;
2062
2063 ret = sdhci_msm_runtime_resume(dev);
2064 if (ret)
2065 return ret;
2066
2067 ret = sdhci_resume_host(host);
2068 if (ret < 0)
2069 return ret;
2070 enable_irq(msm_host->pwr_irq);
2071
2072 if (host->mmc->caps2 & MMC_CAP2_CQE)
> 2073 ret = cqhci_resume(host->mmc);
2074
2075 return ret;
2076 }
2077
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 46552 bytes --]
prev parent reply other threads:[~2020-01-25 15:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 14:30 [PATCH V1] mmc: sdhci-msm: Add system suspend/resume callbacks Shaik Sajida Bhanu
2020-01-21 23:25 ` Matthias Kaehlcke
2020-01-22 7:22 ` Adrian Hunter
2020-01-22 16:57 ` Stephen Boyd
2020-02-06 15:44 ` sbhanu
2020-01-25 15:28 ` kbuild test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202001251815.E5Q9CSnW%lkp@intel.com \
--to=lkp@intel.com \
--cc=adrian.hunter@intel.com \
--cc=agross@kernel.org \
--cc=asutoshd@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=cang@codeaurora.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=rampraka@codeaurora.org \
--cc=sayalil@codeaurora.org \
--cc=sbhanu@codeaurora.org \
--cc=stummala@codeaurora.org \
--cc=ulf.hansson@linaro.org \
--cc=vbadigan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).