From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
swboyd@chromium.org, sivaa@codeaurora.org,
Andy Gross <agross@kernel.org>,
Amit Kucheria <amit.kucheria@verdurent.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 6/7] drivers: thermal: tsens: kernel-doc fixup
Date: Mon, 3 Feb 2020 10:43:20 -0800 [thread overview]
Message-ID: <20200203184320.GH3948@builder> (raw)
In-Reply-To: <1fccb71bd5d54842d2c54d175c080d0edeabca26.1580390127.git.amit.kucheria@linaro.org>
On Thu 30 Jan 05:27 PST 2020, Amit Kucheria wrote:
> Document ul_lock, threshold and control structure members and make
> the following kernel-doc invocation happy:
>
> $ scripts/kernel-doc -v -none drivers/thermal/qcom/*
>
> drivers/thermal/qcom/qcom-spmi-temp-alarm.c:105: info: Scanning doc for qpnp_tm_get_temp_stage
> drivers/thermal/qcom/tsens-common.c:18: info: Scanning doc for struct tsens_irq_data
> drivers/thermal/qcom/tsens-common.c:130: info: Scanning doc for tsens_hw_to_mC
> drivers/thermal/qcom/tsens-common.c:163: info: Scanning doc for tsens_mC_to_hw
> drivers/thermal/qcom/tsens-common.c:245: info: Scanning doc for tsens_set_interrupt
> drivers/thermal/qcom/tsens-common.c:268: info: Scanning doc for tsens_threshold_violated
> drivers/thermal/qcom/tsens-common.c:362: info: Scanning doc for tsens_critical_irq_thread
> drivers/thermal/qcom/tsens-common.c:438: info: Scanning doc for tsens_irq_thread
> drivers/thermal/qcom/tsens.h:41: info: Scanning doc for struct tsens_sensor
> drivers/thermal/qcom/tsens.h:59: info: Scanning doc for struct tsens_ops
> drivers/thermal/qcom/tsens.h:494: info: Scanning doc for struct tsens_features
> drivers/thermal/qcom/tsens.h:513: info: Scanning doc for struct tsens_plat_data
> drivers/thermal/qcom/tsens.h:529: info: Scanning doc for struct tsens_context
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> drivers/thermal/qcom/tsens.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h
> index cf0511a947d4..dd163b27add4 100644
> --- a/drivers/thermal/qcom/tsens.h
> +++ b/drivers/thermal/qcom/tsens.h
> @@ -526,6 +526,8 @@ struct tsens_plat_data {
>
> /**
> * struct tsens_context - Registers to be saved/restored across a context loss
> + * @threshold: Threshold register value
> + * @control: Control register value
> */
> struct tsens_context {
> int threshold;
> @@ -540,6 +542,7 @@ struct tsens_context {
> * @srot_map: pointer to SROT register address space
> * @tm_offset: deal with old device trees that don't address TM and SROT
> * address space separately
> + * @ul_lock: lock while processing upper/lower threshold interrupts
> * @crit_lock: lock while processing critical threshold interrupts
> * @rf: array of regmap_fields used to store value of the field
> * @ctx: registers to be saved and restored during suspend/resume
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-02-03 18:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 13:27 [PATCH v4 0/7] thermal: tsens: Handle critical interrupts Amit Kucheria
2020-01-30 13:27 ` [PATCH v4 1/7] drivers: thermal: tsens: Pass around struct tsens_sensor as a constant Amit Kucheria
2020-01-30 13:27 ` [PATCH v4 2/7] drivers: thermal: tsens: use simpler variables Amit Kucheria
2020-01-30 13:27 ` [PATCH v4 3/7] drivers: thermal: tsens: Release device in success path Amit Kucheria
2020-02-03 18:05 ` Bjorn Andersson
2020-01-30 13:27 ` [PATCH v4 4/7] drivers: thermal: tsens: Add critical interrupt support Amit Kucheria
2020-02-03 18:14 ` Bjorn Andersson
2020-02-18 18:08 ` Amit Kucheria
2020-01-30 13:27 ` [PATCH v4 5/7] drivers: thermal: tsens: Add watchdog support Amit Kucheria
2020-02-03 18:42 ` Bjorn Andersson
2020-02-18 18:08 ` Amit Kucheria
2020-01-30 13:27 ` [PATCH v4 6/7] drivers: thermal: tsens: kernel-doc fixup Amit Kucheria
2020-02-03 18:43 ` Bjorn Andersson [this message]
2020-01-30 13:27 ` [PATCH v4 7/7] drivers: thermal: tsens: Remove unnecessary irq flag Amit Kucheria
2020-02-03 18:44 ` Bjorn Andersson
2020-02-17 15:25 ` [PATCH v4 0/7] thermal: tsens: Handle critical interrupts Daniel Lezcano
2020-02-18 5:36 ` Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203184320.GH3948@builder \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=amit.kucheria@verdurent.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sivaa@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).