From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Amit Kucheria <amit.kucheria@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
swboyd@chromium.org, sivaa@codeaurora.org,
Andy Gross <agross@kernel.org>,
Amit Kucheria <amit.kucheria@verdurent.com>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v4 7/7] drivers: thermal: tsens: Remove unnecessary irq flag
Date: Mon, 3 Feb 2020 10:44:08 -0800 [thread overview]
Message-ID: <20200203184408.GI3948@builder> (raw)
In-Reply-To: <b6db92ea41420c907beb7643f82b6b8011645ac6.1580390127.git.amit.kucheria@linaro.org>
On Thu 30 Jan 05:27 PST 2020, Amit Kucheria wrote:
> IRQF_TRIGGER_HIGH is already specified through devicetree interrupts
> property. Remove it from code.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> drivers/thermal/qcom/tsens.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
> index 5b003d598234..9ee00c67144c 100644
> --- a/drivers/thermal/qcom/tsens.c
> +++ b/drivers/thermal/qcom/tsens.c
> @@ -118,7 +118,7 @@ static int tsens_register(struct tsens_priv *priv)
>
> ret = devm_request_threaded_irq(&pdev->dev, irq,
> NULL, tsens_irq_thread,
> - IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
> + IRQF_ONESHOT,
> dev_name(&pdev->dev), priv);
> if (ret) {
> dev_err(&pdev->dev, "%s: failed to get irq\n", __func__);
> --
> 2.20.1
>
next prev parent reply other threads:[~2020-02-03 18:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 13:27 [PATCH v4 0/7] thermal: tsens: Handle critical interrupts Amit Kucheria
2020-01-30 13:27 ` [PATCH v4 1/7] drivers: thermal: tsens: Pass around struct tsens_sensor as a constant Amit Kucheria
2020-01-30 13:27 ` [PATCH v4 2/7] drivers: thermal: tsens: use simpler variables Amit Kucheria
2020-01-30 13:27 ` [PATCH v4 3/7] drivers: thermal: tsens: Release device in success path Amit Kucheria
2020-02-03 18:05 ` Bjorn Andersson
2020-01-30 13:27 ` [PATCH v4 4/7] drivers: thermal: tsens: Add critical interrupt support Amit Kucheria
2020-02-03 18:14 ` Bjorn Andersson
2020-02-18 18:08 ` Amit Kucheria
2020-01-30 13:27 ` [PATCH v4 5/7] drivers: thermal: tsens: Add watchdog support Amit Kucheria
2020-02-03 18:42 ` Bjorn Andersson
2020-02-18 18:08 ` Amit Kucheria
2020-01-30 13:27 ` [PATCH v4 6/7] drivers: thermal: tsens: kernel-doc fixup Amit Kucheria
2020-02-03 18:43 ` Bjorn Andersson
2020-01-30 13:27 ` [PATCH v4 7/7] drivers: thermal: tsens: Remove unnecessary irq flag Amit Kucheria
2020-02-03 18:44 ` Bjorn Andersson [this message]
2020-02-17 15:25 ` [PATCH v4 0/7] thermal: tsens: Handle critical interrupts Daniel Lezcano
2020-02-18 5:36 ` Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200203184408.GI3948@builder \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=amit.kucheria@verdurent.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sivaa@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).