From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 236F1C3F2D2 for ; Mon, 2 Mar 2020 08:09:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA2E42468E for ; Mon, 2 Mar 2020 08:09:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hxc1+/2q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727059AbgCBIJQ (ORCPT ); Mon, 2 Mar 2020 03:09:16 -0500 Received: from mail-wm1-f51.google.com ([209.85.128.51]:56305 "EHLO mail-wm1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726960AbgCBIJQ (ORCPT ); Mon, 2 Mar 2020 03:09:16 -0500 Received: by mail-wm1-f51.google.com with SMTP id 6so1485869wmi.5 for ; Mon, 02 Mar 2020 00:09:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QIEDA5vG8ySnah38r3nnooZWjoF1SxANwiGeAOn5aus=; b=Hxc1+/2qLFumg1E3nHvgrhfGbDd0W6GUzhRrb85hVtcNCDE0oKietbH1+Kpx7nM9Dd ReJrof+d+xW/Ur3HvZ1jhZg1LPUbC98yCisPAfmvIaJR0aroL28uFIz/CCr/w8vnYYHT KYw6Ys4O0sxoGwto2oOMQ1j5lq4iNRi96mkGi67eyQIGK0tsEHpGlEdGNQblHPOWFtLI UyBAWOvfHIWPrNdbfKJkTcNHPVi76G0jxl8tKxeD8hbIZE8K74m335iwBgXi9faXHrEH eu9XqW5IWfEuS6JKo1UddrtLT8MH3DILVPqyTNDN2VQI50JWy+LZHQh09TWLzO/xK+Rn xb8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QIEDA5vG8ySnah38r3nnooZWjoF1SxANwiGeAOn5aus=; b=ALKl7cWgfo1ZODUT4i68iMpvQXM4EyMpQbyh5Mz0xAY1sPOd7dX019xCD1UncAmi4y Yq/ZXI+FMHh77i/MAlfN7p1H4jbsoc9E+EunYqG1pUsjBgXOIdPVqX9Q+YtTS+IZMX+B b+YaeUBpz7p10y1hmhjBzkdNc/YaX0eflp/oOKy+q5CZoyJekF3HeMuUIY1xcRWUjoJL rsewu1IxZwZxqBzuN5ioO62PBg5sIQBSwPNhb/9Me0POBqIjM3ovDqswSCxNcxDmbVAy GWm5NoS3ScoRmmNl2MrTlH5s1b4zc+lMqUF445F1Tu9R+oOX03RMw0GEOq3U9KrPa7KX BhoA== X-Gm-Message-State: APjAAAV0zMZLoccajBA4VvTTM8nllAic3laUyOKEXFmBt2hGiyz8iRXm F5XSRu9+fSZvdmSMZMJZVTtaE47g X-Google-Smtp-Source: APXvYqwmBD1RYu1hJm1Lol7EWN8ITOWVoo4HPBmYpeRt7oZoBTO86LIDV8S9H3cf6XaYxk4rcOf1ew== X-Received: by 2002:a7b:c305:: with SMTP id k5mr19264575wmj.189.1583136554745; Mon, 02 Mar 2020 00:09:14 -0800 (PST) Received: from localhost (pD9E516A9.dip0.t-ipconnect.de. [217.229.22.169]) by smtp.gmail.com with ESMTPSA id g25sm28977284wmh.3.2020.03.02.00.09.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Mar 2020 00:09:13 -0800 (PST) Date: Mon, 2 Mar 2020 09:09:12 +0100 From: Thierry Reding To: abhinavk@codeaurora.org Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, treding@nvidia.com, daniel.vetter@ffwll.ch, varar@quicinc.com, seanpaul@chromium.org, aravindh@codeaurora.org, chandanu@codeaurora.org Subject: Re: Reverting https://patchwork.freedesktop.org/patch/336850/ Message-ID: <20200302080912.GA1690850@ulmo> References: <8bec962794df6fd8f1384d457060234e@codeaurora.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xHFwDpU9dbj6ez1V" Content-Disposition: inline In-Reply-To: <8bec962794df6fd8f1384d457060234e@codeaurora.org> User-Agent: Mutt/1.13.1 (2019-12-14) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org --xHFwDpU9dbj6ez1V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 28, 2020 at 05:35:51PM -0800, abhinavk@codeaurora.org wrote: > Hi Thierry >=20 > For DP drivers using MSM chipsets, we are using drm_dp_link_configure, > drm_dp_link_power_up and drm_dp_link_power_down functions. Here is the pa= tch > for reference: >=20 > https://patchwork.freedesktop.org/patch/343346/ >=20 > We will be posting a newer version of the driver soon. >=20 > For that, we plan to revert https://patchwork.freedesktop.org/patch/33685= 0/ > as now there are more users of the functions and not just tegra. >=20 > Let us know if this is the right approach or shall we make the required > functions local to our drivers. I think reimplementing these locally in you drivers is the preferred way. It's not so much a lack of users (there were 5 or so in total when I made the change to remove these helpers), but rather the general approach that was being criticized by other driver maintainers. I'm not aware of any of their opinions having changed on this subject, so I'd recommend going down the path of least resistance. Thierry --xHFwDpU9dbj6ez1V Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl5cvyQACgkQ3SOs138+ s6FuWRAAic4BmNGPInfnz8tpJ3zMdR881tl4xLHBVnd0cIlAsN0wR5BgQdyoJ6CJ 5VrRknoD7ksKAF5NSbpfhcfL+MXM8co0nLGdBsQbbOyIh15q2/13csHlgaGq+V1E 6HvPbdXrHHOwy0fLs24P2Qgr/K6lJ7z+Dd6ZOMfJVd8XvKiytliEPNi/hj7UrkBV fdgrMxV4I5n1j3+xjMIGTUnUURj9GHvHCxNChUtxoCpcK/dEaR6ycX6yo2HuNYBL /BYHow1Qls0b+Q4iKjpd4wMBtRE8TDRNe32bV/JnbNL3QIFMq0pkGMvzTJyFbQD3 psmZmy4o4KzzDYifvtvhOF45+7SbYbcEwikBuDLv8FnuKXkj4ven51apoAexzZie DXrG9lojGc4BuHwWYJMrp5EjGHBNGwtUFmBblLMap/A4iVSAgxlxQSnT1tS9RXE0 4g8u9G1iOKwMvOFkCTAvUjzuR52/esEHqWRbeyWdggehESQFhOrz8nGcN3fLYbD0 EKUoyOs1oKsnFmA2LdJdJyMfq6VesIjLizs9tWdMGSpG7XDXIzJOvzcnJp8DRzRB TQRoa/Lg3Kopf3UeMHMWm1UY0ULF/YWc/DDkD2RxPPSpbof1T/RDnsVy5JX2Hltf s3M/dH3m/pQjGmeO6hP5j0cxtRPaURdy1Z8e4TbZDp/nI9qPsIw= =Ac70 -----END PGP SIGNATURE----- --xHFwDpU9dbj6ez1V--