From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 178FEC43331 for ; Fri, 3 Apr 2020 18:16:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5AA2206F5 for ; Fri, 3 Apr 2020 18:16:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="NYx+sHPE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404220AbgDCSQe (ORCPT ); Fri, 3 Apr 2020 14:16:34 -0400 Received: from mail-pj1-f66.google.com ([209.85.216.66]:37506 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728499AbgDCSQd (ORCPT ); Fri, 3 Apr 2020 14:16:33 -0400 Received: by mail-pj1-f66.google.com with SMTP id k3so3296624pjj.2 for ; Fri, 03 Apr 2020 11:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=l9OtO5bBjU4ri0ecYRkCgiryeyjL/1OJpZNChQ7ItYI=; b=NYx+sHPEuWXImveqC5saq7LPSHEW29HyBJwPIy0Wsv4qxJp8hwJZwCQLBGUxkDoz5n NRTdcePZ89Ihj3Nr1q4SSWTYE9L6ixXMinliK5sCArFNnBmm0cTAjVAVEUR491pc7zx+ 7TWCe9R7nyZui0z+kqVrFdlu5SedTFb/AKFV4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=l9OtO5bBjU4ri0ecYRkCgiryeyjL/1OJpZNChQ7ItYI=; b=AFegPgKpD+yl/YiaxfNocvqGitjO+B5lm06NmVue1s8fsMWAEIxztt9qpKW1wEmnni OY3NzPTOVQ5VHdMhbGk9wlLTVVSo2lCPVlRSwaE2BKbi3OZ2tCJx7bXvuplDQ6nACTFW WiYwPCaDQcHfgS1bTMxq0J4AboSznPERH4FfI3qhiKNwNVkxT1XpOB0GwDz8R055Znnu 2SXONCACnx9qq7wA9X8uLVL48gGQEy/CemymK1wMOqa4CXZd3L1rXBCQMtdCVA6x9/9B YjvKZ6MOzBS6J+LM2pI+7yexyKO0lPMIPVzzTbqnk/rg0hXYRFDdaCUSr9NjGiSDIIxw 7Mpg== X-Gm-Message-State: AGi0Pua+oSQvfROveEgwMR6tKAEWvEKvvXfmOzXq0jJnVqtfteuSk+Il 3ysbjsVYBPbUu7tVotPKQMZETw== X-Google-Smtp-Source: APiQypIGHcLKfA4BC6dhIJebo6CEcV70oa/S4T2XWdYpRNyxtEt21rnfykH5/137XQhZwQNCpuZxdQ== X-Received: by 2002:a17:902:d3cb:: with SMTP id w11mr8949903plb.257.1585937792655; Fri, 03 Apr 2020 11:16:32 -0700 (PDT) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id x3sm6250986pfp.167.2020.04.03.11.16.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2020 11:16:30 -0700 (PDT) Date: Fri, 3 Apr 2020 11:16:29 -0700 From: Matthias Kaehlcke To: "Rajeshwari Ravindra Kamble (Temp)" Cc: Amit Kucheria , Doug Anderson , Andy Gross , Rob Herring , Mark Rutland , Bjorn Andersson , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , sivaa@codeaurora.org, Sandeep Maheswaram Subject: Re: [PATCH] arm64: dts: qcom: sc7180: Changed polling-delay in Thermal-zones node Message-ID: <20200403181629.GP199755@google.com> References: <1584430804-8343-1-git-send-email-rkambl@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Rajeshwari, do you plan to send v2 with an updated commit message? Thanks Matthias On Wed, Mar 18, 2020 at 02:40:47PM +0530, Amit Kucheria wrote: > On Wed, Mar 18, 2020 at 11:49 AM Rajeshwari Ravindra Kamble (Temp) > wrote: > > > > > > On 3/17/2020 10:20 PM, Doug Anderson wrote: > > > > Hi, > > > > On Tue, Mar 17, 2020 at 12:42 AM Rajeshwari wrote: > > > > Changed polling-delay and polling-delay-passive to zero as per > > the requirement. > > > > Signed-off-by: Rajeshwari > > --- > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 100 +++++++++++++++++------------------ > > 1 file changed, 50 insertions(+), 50 deletions(-) > > > > It probably wouldn't hurt to mention in the commit message that this > > is because the thermal sensor interrupts are all hooked up and thus > > the polling is not a useful thing to do. ...but other than that: > > > > Reviewed-by: Douglas Anderson > > > > > > Hi Douglas > > > > I didn't get your comment. > > > > Thanks, > > Rajeshwari > > I think he means that you haven't mentioned WHY this patch is needed > in the message. The reason you should mention is "to disable polling > mode of the framework since interrupts for tsens are already > configured." > > Regards, > Amit