From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7381C2BA19 for ; Tue, 14 Apr 2020 18:37:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A34EB2074D for ; Tue, 14 Apr 2020 18:37:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="a4bjsZvz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2504073AbgDNShC (ORCPT ); Tue, 14 Apr 2020 14:37:02 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:37346 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730984AbgDNShB (ORCPT ); Tue, 14 Apr 2020 14:37:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ViDMoOKYM5eKMxDsxHH7qVo/oFOUllzmSiKC3yZPO6c=; b=a4bjsZvzVTQKEboODtQWY+VzaR Uka9txjlohDs9CE42qN9gGt3beuSmKNSmtSo7sK+GvEmNmBdul/j9c1ITfwevq3/jPyfVKOK/ju0h cXqUEA7fx3zAhjjBHSzaQmtEoOu3GpTuVsEJOgDDdlfssYACYEu7t10Syh0LjvN7FKLA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jOQQW-002hvo-0W; Tue, 14 Apr 2020 20:36:52 +0200 Date: Tue, 14 Apr 2020 20:36:52 +0200 From: Andrew Lunn To: Robert Marko Cc: f.fainelli@gmail.com, hkallweit1@gmail.com, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Andy Gross , Bjorn Andersson , robh+dt@kernel.org, Mark Rutland , linux-arm-msm , devicetree@vger.kernel.org, Christian Lamparter , Luka Perkov Subject: Re: [PATCH 1/3] net: phy: mdio: add IPQ40xx MDIO driver Message-ID: <20200414183652.GB637127@lunn.ch> References: <20200413170107.246509-1-robert.marko@sartura.hr> <20200413184219.GH557892@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org > Unfortunately, I don't have access to documentation and this is all based on > GPL code from Qualcomm's SDK. > So I don't really know whats their purpose. Then please try to reverse engineer it. Just looking at the code, it seems like one register is read, and the other is write. So use that in the name. > No, this is also an old relic from the SDK driver. > It works without this perfectly fine, so I will drop it from v2. Part of cleaning up 'Vendor Crap' is throwing out all the stuff like this. What you end up with should be something you would of been happy to write yourself. > > Why the name am? Generally priv is used. I could also understand bus, > > or even data, but am? > Like most stuff in this driver, its a leftover from the SDK driver. I guessed as much. But this is the sort of thing you need to fix when cleaning up 'vendor crap'. Andrew