From: Guenter Roeck <linux@roeck-us.net>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
kbuild test robot <lkp@intel.com>,
Lina Iyer <ilina@codeaurora.org>
Subject: Re: [PATCH] soc: qcom: cmd-db: Properly endian swap the slv_id for debugfs
Date: Fri, 17 Apr 2020 07:05:04 -0700 [thread overview]
Message-ID: <20200417140504.GA98984@roeck-us.net> (raw)
In-Reply-To: <20200417000645.234693-1-swboyd@chromium.org>
On Thu, Apr 16, 2020 at 05:06:45PM -0700, Stephen Boyd wrote:
> Read the slv_id properly by making sure the 16-bit number is endian
> swapped from little endian to CPU native before we read it to figure out
> what to print for the human readable name. Otherwise we may just show
> that all the elements in the cmd-db are "Unknown" which isn't right.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Cc: Lina Iyer <ilina@codeaurora.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/soc/qcom/cmd-db.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> base-commit: d6815c5c43d4f9d18e557d27fd27ae8d9cfd450c
> prerequisite-patch-id: fc235b174200bb1b24876628a89a841d1c2e4aad
> prerequisite-patch-id: df579afb4eaea4200733d9dffb1d75eef8d8360b
>
> diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
> index 4f8b739c6485..fc5610603b17 100644
> --- a/drivers/soc/qcom/cmd-db.c
> +++ b/drivers/soc/qcom/cmd-db.c
> @@ -254,7 +254,7 @@ static int cmd_db_debugfs_dump(struct seq_file *seq, void *p)
> if (!rsc->slv_id)
> break;
>
> - switch (rsc->slv_id) {
> + switch (le16_to_cpu(rsc->slv_id)) {
> case CMD_DB_HW_ARC:
> name = "ARC";
> break;
prev parent reply other threads:[~2020-04-17 14:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 0:06 [PATCH] soc: qcom: cmd-db: Properly endian swap the slv_id for debugfs Stephen Boyd
2020-04-17 14:05 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200417140504.GA98984@roeck-us.net \
--to=linux@roeck-us.net \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).