From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: "Mathias Nyman" <mathias.nyman@linux.intel.com>,
"Mathias Nyman" <mathias.nyman@intel.com>,
linux-arm-msm@vger.kernel.org,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Christian Lamparter" <chunkeey@googlemail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"John Stultz" <john.stultz@linaro.org>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Andreas Böhler" <dev@aboehler.at>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v11 2/5] usb: renesas-xhci: Add the renesas xhci driver
Date: Thu, 30 Apr 2020 16:53:02 +0200 [thread overview]
Message-ID: <20200430145302.GB3495619@kroah.com> (raw)
In-Reply-To: <20200430144641.GJ948789@vkoul-mobl.Dlink>
On Thu, Apr 30, 2020 at 08:16:41PM +0530, Vinod Koul wrote:
> > > diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile
> > > index b191361257cc..c3a79f626393 100644
> > > --- a/drivers/usb/host/Makefile
> > > +++ b/drivers/usb/host/Makefile
> > > @@ -70,7 +70,8 @@ obj-$(CONFIG_USB_OHCI_HCD_DAVINCI) += ohci-da8xx.o
> > > obj-$(CONFIG_USB_UHCI_HCD) += uhci-hcd.o
> > > obj-$(CONFIG_USB_FHCI_HCD) += fhci.o
> > > obj-$(CONFIG_USB_XHCI_HCD) += xhci-hcd.o
> > > -obj-$(CONFIG_USB_XHCI_PCI) += xhci-pci.o
> > > +usb-xhci-pci-objs := xhci-pci.o xhci-pci-renesas.o
> > > +obj-$(CONFIG_USB_XHCI_PCI) += usb-xhci-pci.o
> >
> > I don't think it's a good idea to rename the xhci-pci module to usb-xhci-pci
> >
> > does
> >
> > xhci-pci-y := xhci-pci.o xhci-pci-renesas.o
> > obj-$(CONFIG_USB_XHCI_PCI) += xhci-pci.o
> >
> > cause some kbuild issues?
>
> Yes with this version I get the warning:
> make[4]: Circular drivers/usb/host/xhci-pci.o <- drivers/usb/host/xhci-pci.o dependency dropped.
>
> I don't speak enough Kbuild, but I guess it does make sense that we have
> xhci-pci.o as target for both xhci-pci.o xhci-pci-renesas.o! That was
> the reason for adding usb tag to this to resolve the conflict.
>
> I am okay for any other mechanism which can work well here. Btw what
> issues do you foresee with adding usb tag to module name.
It will break all sorts of things. Happens every time we rename
modules, let's not do it unless we absolutely have to.
greg k-h
next prev parent reply other threads:[~2020-04-30 14:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 10:10 [PATCH v11 0/5] usb: xhci: Add support for Renesas USB controllers Vinod Koul
2020-04-30 10:10 ` [PATCH v11 1/5] usb: hci: add hc_driver as argument for usb_hcd_pci_probe Vinod Koul
2020-04-30 10:10 ` [PATCH v11 2/5] usb: renesas-xhci: Add the renesas xhci driver Vinod Koul
2020-04-30 14:36 ` Mathias Nyman
2020-04-30 14:46 ` Vinod Koul
2020-04-30 14:53 ` Greg Kroah-Hartman [this message]
2020-04-30 15:26 ` Vinod Koul
2020-04-30 15:35 ` Greg Kroah-Hartman
2020-04-30 10:10 ` [PATCH v11 3/5] usb: xhci: Add support for Renesas controller with memory Vinod Koul
2020-04-30 10:10 ` [PATCH v11 4/5] usb: renesas-xhci: Add ROM loader for uPD720201 Vinod Koul
2020-04-30 10:10 ` [PATCH v11 5/5] usb: xhci: provide a debugfs hook for erasing rom Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430145302.GB3495619@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bjorn.andersson@linaro.org \
--cc=chunkeey@googlemail.com \
--cc=dev@aboehler.at \
--cc=john.stultz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=stern@rowland.harvard.edu \
--cc=vkoul@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox