From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: "Mathias Nyman" <mathias.nyman@linux.intel.com>,
"Mathias Nyman" <mathias.nyman@intel.com>,
linux-arm-msm@vger.kernel.org,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Christian Lamparter" <chunkeey@googlemail.com>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"John Stultz" <john.stultz@linaro.org>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Andreas Böhler" <dev@aboehler.at>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v12 2/5] usb: renesas-xhci: Add the renesas xhci driver
Date: Tue, 5 May 2020 14:05:09 +0200 [thread overview]
Message-ID: <20200505120509.GA116918@kroah.com> (raw)
In-Reply-To: <20200505113354.GX1375924@vkoul-mobl>
On Tue, May 05, 2020 at 05:03:54PM +0530, Vinod Koul wrote:
> On 05-05-20, 13:04, Greg Kroah-Hartman wrote:
> > On Mon, May 04, 2020 at 08:04:38PM +0530, Vinod Koul wrote:
>
> > > > > --- a/drivers/usb/host/Makefile
> > > > > +++ b/drivers/usb/host/Makefile
> > > > > @@ -70,7 +70,7 @@ obj-$(CONFIG_USB_OHCI_HCD_DAVINCI) += ohci-da8xx.o
> > > > > obj-$(CONFIG_USB_UHCI_HCD) += uhci-hcd.o
> > > > > obj-$(CONFIG_USB_FHCI_HCD) += fhci.o
> > > > > obj-$(CONFIG_USB_XHCI_HCD) += xhci-hcd.o
> > > > > -obj-$(CONFIG_USB_XHCI_PCI) += xhci-pci.o
> > > > > +obj-$(CONFIG_USB_XHCI_PCI) += xhci-pci.o xhci-pci-renesas.o
> > > >
> > > > Hmm, now we end up with two modules, xhci-pci and xhci-pci-renesas, even if
> > > > xhci-pci-renesas just includes helper functions to load firmware for renesas.
> > >
> > > Right, these are two modules. Do you forsee an issue with two ko's
> >
> > Two kos should be fine, but as you aren't giving people the option to
> > not select this, it's a bit harsh to add it.
> >
> > Can this be a separate module/config option? Why force everyone to need
> > this additional code if they do not have this hardware?
>
> Since the code is moved out and is based on PCI ID of the device, this
> wont be invoked at all for folks not having this hardware. But adding a
> config option would work too and avoid renaming file.
Yes, it would not be "invoked", but it still would always be loaded into
memory. Please only load this code if the hardware is present in the
system.
thanks,
greg k-h
next prev parent reply other threads:[~2020-05-05 12:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 16:59 [PATCH v12 0/5] usb: xhci: Add support for Renesas USB controllers Vinod Koul
2020-04-30 16:59 ` [PATCH v12 1/5] usb: hci: add hc_driver as argument for usb_hcd_pci_probe Vinod Koul
2020-04-30 16:59 ` [PATCH v12 2/5] usb: renesas-xhci: Add the renesas xhci driver Vinod Koul
2020-05-04 13:01 ` Mathias Nyman
2020-05-04 14:34 ` Vinod Koul
2020-05-05 11:04 ` Greg Kroah-Hartman
2020-05-05 11:33 ` Vinod Koul
2020-05-05 12:05 ` Greg Kroah-Hartman [this message]
2020-04-30 16:59 ` [PATCH v12 3/5] usb: xhci: Add support for Renesas controller with memory Vinod Koul
2020-04-30 16:59 ` [PATCH v12 4/5] usb: renesas-xhci: Add ROM loader for uPD720201 Vinod Koul
2020-04-30 16:59 ` [PATCH v12 5/5] usb: xhci: provide a debugfs hook for erasing rom Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200505120509.GA116918@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bjorn.andersson@linaro.org \
--cc=chunkeey@googlemail.com \
--cc=dev@aboehler.at \
--cc=john.stultz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=stern@rowland.harvard.edu \
--cc=vkoul@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox