From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12844C433E1 for ; Mon, 18 May 2020 19:57:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDE2D20657 for ; Mon, 18 May 2020 19:57:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kA7beYhI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728618AbgERT5D (ORCPT ); Mon, 18 May 2020 15:57:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726478AbgERT5C (ORCPT ); Mon, 18 May 2020 15:57:02 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62C0CC05BD09 for ; Mon, 18 May 2020 12:57:01 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id w64so853262wmg.4 for ; Mon, 18 May 2020 12:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=PbdRyg5kcd//DX8aThqSi8QmNWbORlgHp5rh1J6SqIY=; b=kA7beYhILj0prjYk3znsZ8vtZ7ZDrlQiKMA8sojxIRQXdGFCC8xIgp5oYZcsv/epOa z+WwumTl1Z5l7ZX9B/eSRrqY5mx549cQYP//s64DW4RKuMRcjPBWW5fQi5fAZlenSkZJ Nt1WvnhlH1BgUXRpg/hIsSY/DfNuQGXGDvjHA4ulU45A3PQ10l2Ii7oIjU1ZrqUblkDo NA0ch0kHTUl/VyMp6QdehDNFFaESotNNxJsywuZFaJQrnp3f1uIg+jX+nk1vK3Ecm+b4 P6xmu/BErHxodXVZt88F3zAeY0oXRqfODvYoE6KNDpKet9iKSLYq8FddTeCPBpnQTVNX KOyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=PbdRyg5kcd//DX8aThqSi8QmNWbORlgHp5rh1J6SqIY=; b=rIH8+pQBfWN+hz84JFkdY4+/+EKUBdZamPW6yVaSszbmA/x6842kmuRhGfdA/EHrPm 7bR3wCZsOsQTOdMSq+7+66xLF0q+5PqQH1/Not9KmCFgfIB4NpGvfvtkvuu43dyadfQ2 iB+9j+PuRA4FAyecy+NbfhojwXvno/64/Eh8fAxh7WevRcJyo3dnW+CXnfeKs79Xmgcp deQmTU/9Ypk3svyjYWKCpm3Q9Tkd6McsjgOq2ShGtYgKiaXZFG327ugbUkreiLY+oBzu 8VxDvSmQC6EOSOKmtLeTG80G6rFhjg09LgJCHewl0xOc/mYB0eP40izlm6rS2CaGBiQi 3fcQ== X-Gm-Message-State: AOAM531YSsea5AvkwyFW8ODZ1DFyCzI9NoSaCPmL37eqWp529o+d9zap eyUU1oM3Tqn2X3QkEJ0PbB3aRA== X-Google-Smtp-Source: ABdhPJzoU8qbbvxxC3cizf6NI6NFIEqaKyHByjJ4SgRZLqqZ0f2ZQseTGjC1Xa9OdZep5QtoO5pCtw== X-Received: by 2002:a1c:3b87:: with SMTP id i129mr1150807wma.38.1589831819961; Mon, 18 May 2020 12:56:59 -0700 (PDT) Received: from holly.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id u10sm769695wmc.31.2020.05.18.12.56.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2020 12:56:59 -0700 (PDT) Date: Mon, 18 May 2020 20:56:56 +0100 From: Daniel Thompson To: Sam Ravnborg Cc: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Bjorn Andersson , Peter Ujfalusi , Thierry Reding , Lee Jones , Jonathan Corbet , Tomi Valkeinen , Russell King , Andy Gross , Uwe Kleine-Konig , linux-pwm@vger.kernel.org, Michael Hennerich , Bartlomiej Zolnierkiewicz , Jani Nikula , linux-arm-msm@vger.kernel.org, Support Opensource , Jingoo Han , Douglas Anderson , Thomas Zimmermann , patches@opensource.cirrus.com Subject: Re: [PATCH v2 15/16] backlight: make of_find_backlight_by_node() static Message-ID: <20200518195656.z2wag34mbr3e2hip@holly.lan> References: <20200517190139.740249-1-sam@ravnborg.org> <20200517190139.740249-16-sam@ravnborg.org> <20200518165648.ltgtofjsteyyse4j@holly.lan> <20200518181227.GC770425@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200518181227.GC770425@ravnborg.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, May 18, 2020 at 08:12:27PM +0200, Sam Ravnborg wrote: > On Mon, May 18, 2020 at 05:56:48PM +0100, Daniel Thompson wrote: > > On Sun, May 17, 2020 at 09:01:38PM +0200, Sam Ravnborg wrote: > > > There are no external users of of_find_backlight_by_node(). > > > Make it static so we keep it that way. > > > > > > v2: > > > - drop EXPORT of of_find_backlight_by_node > > > > > > Signed-off-by: Sam Ravnborg > > > Cc: Lee Jones > > > Cc: Daniel Thompson > > > Cc: Jingoo Han > > > > Assuming the 0day-ci comments are because some of the patches have > > already been sucked up in a different tree then: > Correct. For now only drm-misc-next have no users of > of_find_backlight_by_node() which is why the other trees failed. > > > > Reviewed-by: Daniel Thompson > Thanks for all your reviews! > I will shortly (within a few days) address the comments and send out a v3. > > Is is correct that I assume you or Lee or Jingoo will apply the patches > to a backlight tree somewhere when they are ready? > If you have a tree you use for backlight patches I can base v3 on that, > given that I get a link and have access to pull from it. Absent holidays and the like, Lee usually does that actual patch hoovering. Daniel.