From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3073DC433E0 for ; Wed, 20 May 2020 15:11:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF67E20671 for ; Wed, 20 May 2020 15:11:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XeXcnSDz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726821AbgETPLH (ORCPT ); Wed, 20 May 2020 11:11:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726439AbgETPLH (ORCPT ); Wed, 20 May 2020 11:11:07 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6BDAC061A0E for ; Wed, 20 May 2020 08:11:05 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id w64so3253693wmg.4 for ; Wed, 20 May 2020 08:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=06NUZT5oLkpj/XtrzauexC0pCoY/y9Ccf9pqJFj0T/w=; b=XeXcnSDzB20IzMYYaQc9pOwritNDhN6imrcAkJ4CQWTpEH4aPAeQSPDPNLbV92j0SA oAawwf0ELlavBL5WcYpoYotPxq3q80A0ycLUmleNIPklD/w0z2hOGmGw3g2l64l0ZcBa +eNoVGxtdarKvXxzaEpRw1bHNhwynO8pkMUwPDu2f7CK39ziSKfFLo4IUJfS5BuGXWQR nUl14WTVTeIchrBTfxakLBZ48pHDzKI1mtdnT6gerck5nHBfTtwAGvbpTOBmcAwxkbGh zO4UXftbsmhDety8B3sp1iDmZItDGTm/tZFBNsRvL0tBlDTZ61eOTckjW8Jx6yh4zDK5 DlSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=06NUZT5oLkpj/XtrzauexC0pCoY/y9Ccf9pqJFj0T/w=; b=diP5TWoPSSdg4wU8osClksYnHtw95vO+HH5WQdilEesFIg4XghF20TvJzwJMkQHQoQ jsJ1qy6QuBDtdD29BeLvqUj5TwJVYznsijadKhELNBU4yNo1ur6STdJyQL/QsLUzJMbf 9bFGY7lDXzIwcwOguWT6XvGOjWptXQaYIVMUnFyrkFmj2/q9lzU808dUiqcXZgAOOpU4 VAQRrDf5atQ1FbJTg8LdyzogrCfrX3u2K3l3uHBAvaA85MJJ7jN5cGFUzFuLK1tuH3gY KPwSoAukjGN5wsEUJ7UVwaq5AyROUXK94QZG3DXBSExFsCgaUfFp/i9gTtYQlHb1c0uj 5KNg== X-Gm-Message-State: AOAM530bgQQCwhHrg1VCAYUQfJCb5acvv+NeCYZaFsq6FPcTGUtXqR7P LaVZeFwdXNCAcpg2dtkn19IMIg== X-Google-Smtp-Source: ABdhPJyXMBtgIyVHWRYhaf2yK4ztGsyMk20Pe4z2hkQyG7pzqRrGTcnZZ8hRIeRanLf0UxioF5MHfg== X-Received: by 2002:a1c:740e:: with SMTP id p14mr5281698wmc.137.1589987464578; Wed, 20 May 2020 08:11:04 -0700 (PDT) Received: from holly.lan (cpc141214-aztw34-2-0-cust773.18-1.cable.virginm.net. [86.9.19.6]) by smtp.gmail.com with ESMTPSA id p10sm3297653wra.78.2020.05.20.08.11.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2020 08:11:03 -0700 (PDT) Date: Wed, 20 May 2020 16:11:01 +0100 From: Daniel Thompson To: Emil Velikov Cc: Sam Ravnborg , ML dri-devel , Jingoo Han , Lee Jones , Peter Ujfalusi , Tomi Valkeinen , linux-pwm@vger.kernel.org, Support Opensource , Michael Hennerich , Bartlomiej Zolnierkiewicz , David Airlie , Daniel Vetter , Jonathan Corbet , Douglas Anderson , Bjorn Andersson , Jani Nikula , Andy Gross , Thierry Reding , Thomas Zimmermann , linux-arm-msm , Russell King , patches@opensource.cirrus.com, Uwe Kleine-Konig Subject: Re: [PATCH v2 16/16] backlight: use backlight_is_blank() in all backlight drivers Message-ID: <20200520151101.tp4eaiadqq36wyy7@holly.lan> References: <20200517190139.740249-1-sam@ravnborg.org> <20200517190139.740249-17-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, May 20, 2020 at 11:56:43AM +0100, Emil Velikov wrote: > Hi Sam, > > On Sun, 17 May 2020 at 20:02, Sam Ravnborg wrote: > > > --- a/drivers/video/backlight/88pm860x_bl.c > > +++ b/drivers/video/backlight/88pm860x_bl.c > > @@ -123,13 +123,7 @@ static int pm860x_backlight_update_status(struct backlight_device *bl) > > { > > int brightness = bl->props.brightness; > > > > - if (bl->props.power != FB_BLANK_UNBLANK) > > - brightness = 0; > > - > > - if (bl->props.fb_blank != FB_BLANK_UNBLANK) > > - brightness = 0; > > - > > - if (bl->props.state & BL_CORE_SUSPENDED) > > + if (backlight_is_blank(bl)) > > brightness = 0; > Off the top of my head, the above two lines should really be in backlight core. > There's nothing driver specific to them, plus it minimises the chances > of next-driver getting it wrong. > > > > --- a/drivers/video/backlight/as3711_bl.c > > +++ b/drivers/video/backlight/as3711_bl.c > > @@ -107,13 +107,11 @@ static int as3711_bl_update_status(struct backlight_device *bl) > > int brightness = bl->props.brightness; > > int ret = 0; > > > > - dev_dbg(&bl->dev, "%s(): brightness %u, pwr %x, blank %x, state %x\n", > > + dev_dbg(&bl->dev, "%s(): brightness %u, pwr %x, state %x\n", > > __func__, bl->props.brightness, bl->props.power, > > - bl->props.fb_blank, bl->props.state); > > + bl->props.state); > > > Let's also move this to backlight core. Or just nuke it ;-) Daniel.