Re: [PATCH v3 0/7] Venus dynamic debug

Joe Perches
2020-06-09T16:40:42Z

On Tue, 2020-06-09 at 13:45 +0300, Stanimir Varbanov wrote:
> Hello,
>
> Here is the third version of dynamic debug improvements in Venus
> driver. As has been suggested on previous version by Joe [1] I've
> made the relevant changes in dynamic debug core to handle leveling
> as more generic way and not open-code/workaround it in the driver.
>
> About changes:
> - added change in the dynamic_debug and in documentation
> - added respective pr_debug_level and dev_dbg_level
>
> regards,
> Stan
>
> [1] https://lkml.org/lkml/2020/5/21/668

This capability is already clumsily used by many
drivers that use a module level "debug" flag.

$ git grep -P "MODULE_PARM.*\bdebug\b"|wc -l
501

That's a _lot_ of homebrewed mechanisms.

Making dynamic debug have this as a feature would
help consolidate and standardize the capability.

ftrace is definitely useful, but not quite as
lightweight and doesn't have the typical uses.