Re: [PATCH v2 4/6] regulator: Add support for QCOM PMIC VBUS booster

Wesley Cheng
2020-06-16T04:21:49Z

On 6/12/2020 8:28 PM, Randy Dunlap wrote:
> On 6/12/20 4:19 PM, Wesley Cheng wrote:
>> diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig
>> index 074a2ef55943..f9165f9f9051 100644
>> --- a/drivers/regulator/Kconfig
>> +++ b/drivers/regulator/Kconfig
>> @@ -797,6 +797,16 @@ config REGULATOR_QCOM_SPMI
>> Qualcomm SPMI PMICs as a module. The module will be named
>> "qcom_spmi-regulator".
>>
>> +config REGULATOR_QCOM_USB_VBUS
>> + tristate "Qualcomm USB Vbus regulator driver"
>> + depends on SPMI || COMPILE_TEST
>> + help
>> + If you say yes to this option, support will be included for the
>> + regulator used to enable the VBUS output.
>> +
>> + Say M here if you want to include support for enabling the VBUS output
>> + as a module. The module will be named "qcom_usb-regulator".
>
> Hi,
> Shouldn't that module name match what is in the Makefile?
>
>

Thanks, Randy. Missed this as I was going back and forth on the file
name. Thanks for the catch.

>> +
>> config REGULATOR_RC5T583
>> tristate "RICOH RC5T583 Power regulators"
>> depends on MFD_RC5T583
>> diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile
>> index c0d6b96ebd78..cbab28aa7b56 100644
>> --- a/drivers/regulator/Makefile
>> +++ b/drivers/regulator/Makefile
>> @@ -89,6 +89,7 @@ obj-$(CONFIG_REGULATOR_QCOM_RPM) += qcom_rpm-regulator.o
>> obj-$(CONFIG_REGULATOR_QCOM_RPMH) += qcom-rpmh-regulator.o
>> obj-$(CONFIG_REGULATOR_QCOM_SMD_RPM) += qcom_smd-regulator.o
>> obj-$(CONFIG_REGULATOR_QCOM_SPMI) += qcom_spmi-regulator.o
>> +obj-$(CONFIG_REGULATOR_QCOM_USB_VBUS) += qcom_usb_vbus-regulator.o
>> obj-$(CONFIG_REGULATOR_PALMAS) += palmas-regulator.o
>> obj-$(CONFIG_REGULATOR_PFUZE100) += pfuze100-regulator.o
>> obj-$(CONFIG_REGULATOR_PV88060) += pv88060-regulator.o
>
>
> thanks.
>