Linux ARM-MSM sub-architecture
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v4 2/3] venus: Make debug infrastructure more flexible
Date: Sun, 14 Jun 2020 08:37:10 +0200	[thread overview]
Message-ID: <20200614063710.GB2611869@kroah.com> (raw)
In-Reply-To: <20200613223919.7038-3-stanimir.varbanov@linaro.org>

On Sun, Jun 14, 2020 at 01:39:18AM +0300, Stanimir Varbanov wrote:
>  	if (slot == -1) {
> -		dev_dbg(inst->core->dev, "%s: no free slot\n", __func__);
> +		VDBGH("no free slot for timestamp\n");

Again, no, you just lost a lot of valuable information by changing to a
different format (like driver, specific device, etc.).  Please don't do
this, it just makes the information less than before.

thanks,

greg k-h

  reply	other threads:[~2020-06-14  6:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-13 22:39 [PATCH v4 0/3] Venus dynamic debug Stanimir Varbanov
2020-06-13 22:39 ` [PATCH v4 1/3] venus: Add debugfs interface to set firmware log level Stanimir Varbanov
2020-06-14  6:35   ` Greg KH
2020-06-15 10:34     ` Stanimir Varbanov
2020-06-13 22:39 ` [PATCH v4 2/3] venus: Make debug infrastructure more flexible Stanimir Varbanov
2020-06-14  6:37   ` Greg KH [this message]
2020-06-15  9:55     ` Stanimir Varbanov
2020-06-15 12:03       ` Greg KH
2020-06-16 11:23         ` Stanimir Varbanov
2020-06-13 22:39 ` [PATCH v4 3/3] venus: Add a debugfs file for SSR trigger Stanimir Varbanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200614063710.GB2611869@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=stanimir.varbanov@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox