Re: [PATCH v3 2/6] dt-bindings: usb: Add Qualcomm PMIC type C controller dt-binding

Rob Herring
2020-06-18T18:33:34Z

On Wed, Jun 17, 2020 at 12:02 PM Wesley Cheng <wcheng@codeaurora.org> wrote:
>
> Introduce the dt-binding for enabling USB type C orientation and role
> detection using the PM8150B. The driver will be responsible for receiving
> the interrupt at a state change on the CC lines, reading the orientation/role,
> and communicating this information to the remote clients, which can include
> a role switch node and a type C switch.
>
> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
> ---
> .../bindings/usb/qcom,pmic-typec.yaml | 117 ++++++++++++++++++
> 1 file changed, 117 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
>
> diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> new file mode 100644
> index 000000000000..085b4547d75a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> @@ -0,0 +1,117 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/usb/qcom,pmic-typec.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Qualcomm PMIC based USB type C Detection Driver
> +
> +maintainers:
> + - Wesley Cheng <wcheng@codeaurora.org>
> +
> +description: |
> + Qualcomm PMIC Type C Detect
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,pm8150b-usb-typec
> +
> + reg:
> + maxItems: 1
> + description: Type C base address
> +
> + interrupts:
> + maxItems: 1
> + description: CC change interrupt from PMIC
> +
> + connector:
> + description: Connector type for remote endpoints
> + type: object

You are duplicating everything in usb-connector.yaml. You should have
a $ref to it.

> +
> + properties:
> + compatible:
> + enum:
> + - usb-c-connector
> +
> + power-role:
> + enum:
> + - dual
> + - source
> + - sink
> +
> + data-role:
> + enum:
> + - dual
> + - host
> + - device
> +
> + port:
> + description: Remote endpoint connections
> + type: object
> +
> + properties:
> + endpoint@0:
> + description: Connection to USB type C mux node

This is wrong. The connector binding says port 0 is the connection the
USB HS controller.

What's a type C mux node? Is there a binding for that? There's an
ongoing discussion with the CrOS folks on how to describe Alt mode
mux/switches.

> + type: object
> +
> + properties:
> + remote-endpoint:
> + maxItems: 1
> + description: Node reference to the type C mux
> +
> + endpoint@1:
> + description: Connection to role switch node

Again, what's this?

> + type: object
> +
> + properties:
> + remote-endpoint:
> + maxItems: 1
> + description: Node reference to the role switch node
> +
> + required:
> + - compatible
> +
> +required:
> + - compatible
> + - interrupts
> + - connector
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + pm8150b {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + qcom,typec@1500 {
> + compatible = "qcom,pm8150b-usb-typec";
> + reg = <0x1500>;
> + interrupts =
> + <0x2 0x15 0x5 IRQ_TYPE_EDGE_RISING>;
> +
> + connector {
> + compatible = "usb-c-connector";
> + power-role = "dual";
> + data-role = "dual";
> + port {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + usb3_data_ss: endpoint@0 {
> + reg = <0>;
> + remote-endpoint =
> + <&qmp_ss_mux>;
> + };
> +
> + usb3_role: endpoint@1 {
> +
> + reg = <1>;
> + remote-endpoint =
> + <&dwc3_drd_switch>;
> + };
> + };
> + };
> + };
> + };
> +...
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>