Re: [RESEND PATCHv3 1/2] dt-bindings: watchdog: Convert QCOM watchdog timer bindings to YAML

Guenter Roeck
2020-06-30T20:37:57Z

On Fri, Jun 26, 2020 at 12:59:04AM +0530, Sai Prakash Ranjan wrote:
> Convert QCOM watchdog timer bindings to DT schema format using
> json-schema.
>
> Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> Reviewed-by: Rob Herring <robh@kernel.org>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> .../devicetree/bindings/watchdog/qcom-wdt.txt | 28 ------------
> .../bindings/watchdog/qcom-wdt.yaml | 44 +++++++++++++++++++
> 2 files changed, 44 insertions(+), 28 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> create mode 100644 Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt b/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> deleted file mode 100644
> index 41aeaa2ff0f8..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/qcom-wdt.txt
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -Qualcomm Krait Processor Sub-system (KPSS) Watchdog
> ----------------------------------------------------
> -
> -Required properties :
> -- compatible : shall contain only one of the following:
> -
> - "qcom,kpss-wdt-msm8960"
> - "qcom,kpss-wdt-apq8064"
> - "qcom,kpss-wdt-ipq8064"
> - "qcom,kpss-wdt-ipq4019"
> - "qcom,kpss-timer"
> - "qcom,scss-timer"
> - "qcom,kpss-wdt"
> -
> -- reg : shall contain base register location and length
> -- clocks : shall contain the input clock
> -
> -Optional properties :
> -- timeout-sec : shall contain the default watchdog timeout in seconds,
> - if unset, the default timeout is 30 seconds
> -
> -Example:
> - watchdog@208a038 {
> - compatible = "qcom,kpss-wdt-ipq8064";
> - reg = <0x0208a038 0x40>;
> - clocks = <&sleep_clk>;
> - timeout-sec = <10>;
> - };
> diff --git a/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> new file mode 100644
> index 000000000000..5448cc537a03
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/qcom-wdt.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/qcom-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Krait Processor Sub-system (KPSS) Watchdog timer
> +
> +maintainers:
> + - Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
> +
> +allOf:
> + - $ref: watchdog.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,kpss-timer
> + - qcom,kpss-wdt
> + - qcom,kpss-wdt-apq8064
> + - qcom,kpss-wdt-ipq4019
> + - qcom,kpss-wdt-ipq8064
> + - qcom,kpss-wdt-msm8960
> + - qcom,scss-timer
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +examples:
> + - |
> + watchdog@208a038 {
> + compatible = "qcom,kpss-wdt-ipq8064";
> + reg = <0x0208a038 0x40>;
> + clocks = <&sleep_clk>;
> + timeout-sec = <10>;
> + };