From: Vinod Koul <vkoul@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: qcom: remove ufs qmp phy driver
Date: Wed, 8 Jul 2020 16:38:46 +0530 [thread overview]
Message-ID: <20200708110846.GD34333@vkoul-mobl> (raw)
In-Reply-To: <20200707050837.GN11847@yoga>
On 06-07-20, 22:08, Bjorn Andersson wrote:
> On Mon 29 Jun 21:54 PDT 2020, Vinod Koul wrote:
>
> > Hi Bjorn,
> >
> > On 29-06-20, 12:24, Bjorn Andersson wrote:
> > > On Mon 29 Jun 07:54 PDT 2020, Vinod Koul wrote:
> > >
> > > > UFS QMP phy drivers are duplicate as we are supposed to use common QMP
> > > > phy driver which is working fine on various platforms. So remove the
> > > > unused driver
> > > >
> > >
> > > This describes the current state, but the UFS QMP driver had a purpose
> > > not that long ago and I would like the commit message to describe what
> > > changed and why it's now fine to remove the driver.
> >
> > Would below look better, also feel free to suggest as you have the
> > more history on this :)
> >
> > "UFS QMP driver is dedicated driver for QMP phy for UFS variant. We
> > also have a common QMP phy driver which works not only for UFS but
> > USB and PCIe as well, so retire this driver in favour of the common
> > driver"
> >
>
> How about:
>
> "The UFS specific QMP PHY driver started off supporting the 14nm and
> 20nm hardware. With the 20nm support marked broken for a long time and
> the 14nm support added to the common QMP PHY, this driver has not been
> used in a while. So delete it."
I have applied it with above log, thanks
--
~Vinod
prev parent reply other threads:[~2020-07-08 11:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 14:54 [PATCH] phy: qcom: remove ufs qmp phy driver Vinod Koul
2020-06-29 19:24 ` Bjorn Andersson
2020-06-30 4:54 ` Vinod Koul
2020-07-07 5:08 ` Bjorn Andersson
2020-07-08 11:08 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708110846.GD34333@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox