From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97552C433E1 for ; Thu, 16 Jul 2020 15:09:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7150D207E8 for ; Thu, 16 Jul 2020 15:09:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JIsaQgcO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728273AbgGPPJ2 (ORCPT ); Thu, 16 Jul 2020 11:09:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726963AbgGPPJ1 (ORCPT ); Thu, 16 Jul 2020 11:09:27 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F78AC061755 for ; Thu, 16 Jul 2020 08:09:27 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id w3so11940007wmi.4 for ; Thu, 16 Jul 2020 08:09:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=wfTVEgJCM3Mx2ShOcrbGhi57eh5VniqIcsBsFPVxDMQ=; b=JIsaQgcOlfc1snytddMtZoMFDfykhaeqOlXeq1BdwR7CE0s3ZN1P7PART5hVNyrINm J4lJuTBjyirv5Vk34La3RjIatruJtd5YCU1nqKG9stWPQjYuQEzH881BV16vzYPK2Dea 5qy30/h3s7mt5hyCdPcjhM2+sVSQBJN9JZEj4+WGmiuzLLjxBg2FmL9w31SvMo+0v0gQ uDlHdi3eeGEntYEDDabA+hvWlsEtCSFhjHCwoSNXIuVEyVu+3UUwuAsHbf9gRSqajAFp y2E9F2ieus6X6FgL4sv0Q9V12aGYccH/0nw7kQ1opDF6eIVoJ+/YNwnfdEhsSifamBRL YgnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=wfTVEgJCM3Mx2ShOcrbGhi57eh5VniqIcsBsFPVxDMQ=; b=iKAMHDDWTuORQMNqxOY7ZXQTQxqEMVaJRu/BLIJfYTa+BILk85wzm9+7smr1+zcpih PC6K5LBU7enWj5OyViBKlrYfcf03NtnCTPiowOwnIoFNqQz14bN1BRJALbGgCb09AL7Y mnUztril5ewc2sb6RHchdmXVmhw0zCYAZ0XXMZlC3VpnBvVV8h1BfmLfmn5gNpv38j8f FNseoXNvgf0mE5Oc810mbV00y5C9aPs0C9DK9N7f4W2qCF1Akq5l+2GlXfqsZUkSPvdB Ypt8VoDBtvfBljYsoPJ5qrwUi78h7FtNVotVU3vDnNSAViIs2jbL8gJLUoQVxooVdsZC m0yA== X-Gm-Message-State: AOAM531MrRlzNtuFlY4dWRetsJ6o+ne1RDGhyATYa3Xvn73tyl0j5Unk gDFoUFlF6Or9Z/nDi3y8u1/9ng== X-Google-Smtp-Source: ABdhPJwJtZ75Fe6xQKoWPm0JZoQfZmxBLgKksLYrLabK8E2UskeVzYq5S2vTJLxmhzHmqHakCWeJRA== X-Received: by 2002:a1c:7416:: with SMTP id p22mr4787367wmc.32.1594912165892; Thu, 16 Jul 2020 08:09:25 -0700 (PDT) Received: from dell ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id 33sm10400383wri.16.2020.07.16.08.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jul 2020 08:09:25 -0700 (PDT) Date: Thu, 16 Jul 2020 16:09:23 +0100 From: Lee Jones To: Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, Jingoo Han , Daniel Thompson , Andy Gross , Bartlomiej Zolnierkiewicz , Bjorn Andersson , Daniel Vetter , David Airlie , Emil Velikov , Jonathan Corbet , linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Michael Hennerich , patches@opensource.cirrus.com, Support Opensource , Thierry Reding , Thomas Zimmermann , Uwe Kleine-Konig , Peter Ujfalusi , Tomi Valkeinen Subject: Re: [PATCH v4 05/20] backlight: improve backlight_device documentation Message-ID: <20200716150923.GY3165313@dell> References: <20200703184546.144664-1-sam@ravnborg.org> <20200703184546.144664-6-sam@ravnborg.org> <20200716143941.GS3165313@dell> <20200716150021.GA1936267@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200716150021.GA1936267@ravnborg.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, 16 Jul 2020, Sam Ravnborg wrote: > Hi Lee. > > On Thu, Jul 16, 2020 at 03:39:41PM +0100, Lee Jones wrote: > > On Fri, 03 Jul 2020, Sam Ravnborg wrote: > > > > > Improve the documentation for backlight_device and > > > adapt it to kernel-doc style. > > > > > > The updated documentation is more strict on how locking is used. > > > With the update neither update_lock nor ops_lock may be used > > > outside the backlight core. > > > This restriction was introduced to keep the locking simple > > > by keeping it in the core. > > > It was verified that this documents the current state by renaming > > > update_lock => bl_update_lock and ops_lock => bl_ops_lock. > > > The rename did not reveal any uses outside the backlight core. > > > The rename is NOT part of this patch. > > > > > > v3: > > > - Update changelog to explain locking details (Daniel) > > > > > > v2: > > > - Add short intro to all fields (Daniel) > > > - Updated description of update_lock (Daniel) > > > > > > Signed-off-by: Sam Ravnborg > > > Reviewed-by: Emil Velikov > > > Cc: Lee Jones > > > Cc: Daniel Thompson > > > Cc: Jingoo Han > > > --- > > > include/linux/backlight.h | 72 ++++++++++++++++++++++++++------------- > > > 1 file changed, 49 insertions(+), 23 deletions(-) > > > > Some of these do not apply cleanly. > > > > Please collect the *-bys already received, rebase and resubmit. > > Will do. > The patch-set is based on drm-misc-next. Are there another > tree that I should use? I don't have anything to do with that tree. Either Backlight [0] or Next would be fine. [0] https://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git/ -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog