Re: [PATCH v4 05/20] backlight: improve backlight_device documentation

[Sam Ravnborg <sam@ravnborg.org>]

Hi Jingoo
On Sat, Jul 18, 2020 at 05:18:39AM +0000, Jingoo Han wrote:
> On 7/3/20, 2:46 PM, Sam Ravnborg wrote:
> >
> > Improve the documentation for backlight_device and
> > adapt it to kernel-doc style.
> >
> > The updated documentation is more strict on how locking is used.
> > With the update neither update_lock nor ops_lock may be used
> > outside the backlight core.
> > This restriction was introduced to keep the locking simple
> > by keeping it in the core.
> > It was verified that this documents the current state by renaming
> > update_lock => bl_update_lock and ops_lock => bl_ops_lock.
> > The rename did not reveal any uses outside the backlight core.
> > The rename is NOT part of this patch.
> >
> > v3:
> >   - Update changelog to explain locking details (Daniel)
> >
> > v2:
> >   - Add short intro to all fields (Daniel)
> >   - Updated description of update_lock (Daniel)
> >
> > Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
>  > Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
> > Cc: Lee Jones <lee.jones@linaro.org>
> > Cc: Daniel Thompson <daniel.thompson@linaro.org>
> > Cc: Jingoo Han <jingoohan1@gmail.com>
> 
> It looks good!
> Reviewed-by: Jingoo Han <jingoohan1@gmail.com>

Thanks!

> 
> For the rebase, if you don't know which branch of maintainer's git can be used,
> linux-next tree [1] is useful. The linux-next git collects all next branches from 
> other maintainers' git every day.
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/

I had used drm-misc-next because the original focus was to clean up
drivers in gpu/drm/ - and then I just continued to use this wrong tree.
linux-next is indeed a good place to catch the latest and greatest - but
as I now have the URL for the backlight tree (thanks to Lee) I will use it here.
Will try to find time this weekend so we can land these.

	Sam