From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E192C43446 for ; Mon, 20 Jul 2020 09:14:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F81622B4E for ; Mon, 20 Jul 2020 09:14:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728091AbgGTJOi (ORCPT ); Mon, 20 Jul 2020 05:14:38 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:55006 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728017AbgGTJOh (ORCPT ); Mon, 20 Jul 2020 05:14:37 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 5E31220027; Mon, 20 Jul 2020 11:14:29 +0200 (CEST) Date: Mon, 20 Jul 2020 11:14:27 +0200 From: Sam Ravnborg To: Daniel Thompson Cc: dri-devel@lists.freedesktop.org, Jingoo Han , Lee Jones , Andy Gross , Bartlomiej Zolnierkiewicz , Bjorn Andersson , Daniel Vetter , David Airlie , Emil Velikov , Jonathan Corbet , linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Michael Hennerich , patches@opensource.cirrus.com, Support Opensource , Thierry Reding , Thomas Zimmermann , Uwe Kleine-Konig , Peter Ujfalusi , Tomi Valkeinen Subject: Re: [PATCH v5 14/19] backlight: cr_bllcd: introduce gpio-backlight semantics Message-ID: <20200720091427.GA140081@ravnborg.org> References: <20200719080743.8560-1-sam@ravnborg.org> <20200719080743.8560-15-sam@ravnborg.org> <20200720084822.wt5guzetkrgbgdcc@holly.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200720084822.wt5guzetkrgbgdcc@holly.lan> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=f+hm+t6M c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=KKAkSRfTAAAA:8 a=pGLkceISAAAA:8 a=OARlJtXb7fUog6UZhKUA:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=cvBusfyB2V15izCimMoJ:22 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Jul 20, 2020 at 09:48:22AM +0100, Daniel Thompson wrote: > On Sun, Jul 19, 2020 at 10:07:38AM +0200, Sam Ravnborg wrote: > > cr_bllcd can turn backlight ON or OFF. > > Fix semantitics so they equals what we know from gpio-backlight. > > brightness == 0 => backlight off > > brightness == 1 => backlight on > > > > Use the backlight_get_brightness() helper to simplify the code. > > > > v2: > > - reworked to introduce gpio-backlight semantics (Daniel) > > Wasn't this added for v5? However, I spotted this change amoung the > other patches so no worries... I do not increment version for individual patches unless there are changes. So this is the second version of this patch, but included in the v5 submission. But I can see how this can confuse the receiver. I will consider to adapt to the practice to indicate version of submission and not the individual patches. > > > > Signed-off-by: Sam Ravnborg > > Cc: Lee Jones > > Cc: Daniel Thompson > > Cc: Jingoo Han > > Reviewed-by: Daniel Thompson Very much appreciated - thanks! Sam