From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 957E7C433E1 for ; Mon, 20 Jul 2020 11:01:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C28522BF3 for ; Mon, 20 Jul 2020 11:01:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728404AbgGTLBU (ORCPT ); Mon, 20 Jul 2020 07:01:20 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:53528 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728232AbgGTLBU (ORCPT ); Mon, 20 Jul 2020 07:01:20 -0400 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 7C830804BA; Mon, 20 Jul 2020 13:01:13 +0200 (CEST) Date: Mon, 20 Jul 2020 13:01:12 +0200 From: Sam Ravnborg To: Lee Jones Cc: dri-devel@lists.freedesktop.org, Jingoo Han , Daniel Thompson , Andy Gross , Bartlomiej Zolnierkiewicz , Bjorn Andersson , Daniel Vetter , David Airlie , Emil Velikov , Jonathan Corbet , linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Michael Hennerich , patches@opensource.cirrus.com, Support Opensource , Thierry Reding , Thomas Zimmermann , Uwe Kleine-Konig , Peter Ujfalusi , Tomi Valkeinen Subject: Re: [PATCH v5 0/19] backlight: backlight updates Message-ID: <20200720110112.GA147689@ravnborg.org> References: <20200719080743.8560-1-sam@ravnborg.org> <20200720093601.GA3368211@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200720093601.GA3368211@dell> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=aP3eV41m c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=fxJcL_dCAAAA:8 a=xWK_zBApGLd1q-zgG6wA:9 a=CjuIK1q_8ugA:10 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Lee. On Mon, Jul 20, 2020 at 10:36:01AM +0100, Lee Jones wrote: > On Sun, 19 Jul 2020, Sam Ravnborg wrote: > > > Hi all. > > > > Follow-up on v4 - with only a few changes listed below and > > in the individual patches. > > Thanks for all the reviews and the feedback on the patches! > > > > I am planning a follow-up on this patchset to update the > > backlight drivers all over to use backlight_get_brightness() > > and backlight_is_blank() as appropriate. > > [...] > > > Sam Ravnborg (19): > > backlight: refactor fb_notifier_callback() > > backlight: add backlight_is_blank() > > backlight: improve backlight_ops documentation > > backlight: improve backlight_properties documentation > > backlight: improve backlight_device documentation > > backlight: document inline functions in backlight.h > > backlight: document enums in backlight.h > > backlight: remove the unused backlight_bl driver > > backlight: drop extern from prototypes > > backlight: add overview and update existing doc > > backlight: wire up kernel-doc documentation > > backlight: introduce backlight_get_brightness() > > backlight: as3711_bl: simplify update_status > > backlight: cr_bllcd: introduce gpio-backlight semantics > > backlight: gpio_backlight: simplify update_status() > > backlight: jornada720_bl: introduce backlight_is_blank() > > backlight: use backlight_get_brightness() > > backlight: drop backlight_put() > > backlight: make of_find_backlight static > > All applied, but to be honest, that was quite painful. That was not the intention :-( > > A few notes for subsequent patches. > > - Enable spell-checkers in your editors > - I fixed the issues up for you here - there were quite a few! > - Run ./checkpatch.pl before submitting - here's what I find useful > * .git/hooks/post-commit: https://pastebin.ubuntu.com/p/WpPFd6M2rB/ > - Please keep the in-patch changelog below the '---' line, so that it > does not end up in the final commit log > - Cc: lines *above* the *-bys please > - Cc: lines dropped for any *-bys provided > - Lines wrapped ~72 chars (not 50) > - One whole empty line spacing between paragraphs > - Ensure you use the formatting expected of the subsystem - in the > case of Backlight it's: > > : : Subject beginning with an upper-case char > > A `git log --oneline -- subsystem` would give you a good idea of > what's expected. Thanks for the input - I will use these points as guideline for the next batch of backlight patches. Sam