From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2027AC433E1 for ; Sat, 22 Aug 2020 15:45:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E71F920658 for ; Sat, 22 Aug 2020 15:45:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gf35XWZX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728214AbgHVPpp (ORCPT ); Sat, 22 Aug 2020 11:45:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727899AbgHVPpp (ORCPT ); Sat, 22 Aug 2020 11:45:45 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B91C2C061573; Sat, 22 Aug 2020 08:45:44 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id d188so2589385pfd.2; Sat, 22 Aug 2020 08:45:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IXMN6fEebBghQDz3Sqca3YX9/vkJ2tbfbXYDEhrSyKo=; b=gf35XWZXEj5GV7U2m6oHKoz9KHqjTI1AL4g1ijXGZiZYTeLI9UzSauPbSRwuSBe9iQ hKsTtmHqu0zNRqhVv3Q8a4AW1Bz1oqYtj+YfZymAP4bKZrPImP22HpH2q/5tceJ49Qq+ rET5pJr8lOvIMF5xK1GgX/uNf3dA1qtqBWtltC7WKQfakMvHCQLaQ6kuTTobH0E+rSzX Jdg74MR/67yZg0q6gIgRIVsGjZGOMAnFgqBY0DbBw1WWlwHOjPISg4Hl0tojTZwJ39U/ U/EBtRP0SMYk9Pam9NOfkx3W+0Xb8CmxSfKfzNgrpJd3dui8P7gSYY73Mx/4kcrz51Vg Hnyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=IXMN6fEebBghQDz3Sqca3YX9/vkJ2tbfbXYDEhrSyKo=; b=VhjkMW/Dv2nK8rBLaJHOaPck70iRRWtH+28ubvRvcwFK0XIH+6/ekn2GUlOAI6mwhO ueVTk7rQy9V0DrSAZCfy5nwExHLEcXIDvN8RfVFv+G3gS1awBivDdjr99TlkHHGw7e7j /cZBlaUkb45iDp5CKXTxnJY2nRP9+z83jJluJ+9wmNZNNXNydktTdq/tCTvt9p/O06HX GaCWBy/VGQn/WVs9wVIbRI3O3e3HXRoI7JYWU1VGwmuJtHOlkjjjv8bxEPIi2cTHFWD+ aEnPegPlV6AgpF1Z12v/pFbMtppf3vLcWAXIv1zCY0YqJwBIdPtGCSNpZJ6VrVYpygrr WaLg== X-Gm-Message-State: AOAM530wz4RDBb1/PiBfjWPs+Iha3EqvURielAmpZnPTKgBlbB4Esd9T JYkNYRHNS/dxo8BNcRNJUl8= X-Google-Smtp-Source: ABdhPJyitP5N04lNk7FwknjiMps+Nbd7PGTFMfTCOtFGY3FCLW8zJIltpgTHQhNESAGI6k+HLIErbw== X-Received: by 2002:a63:ba5e:: with SMTP id l30mr553815pgu.425.1598111144187; Sat, 22 Aug 2020 08:45:44 -0700 (PDT) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id n12sm6341236pfj.99.2020.08.22.08.45.43 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Aug 2020 08:45:43 -0700 (PDT) Date: Sat, 22 Aug 2020 08:45:42 -0700 From: Guenter Roeck To: Maulik Shah Cc: swboyd@chromium.org, mka@chromium.org, evgreen@chromium.org, bjorn.andersson@linaro.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, agross@kernel.org, dianders@chromium.org, rnayak@codeaurora.org, ilina@codeaurora.org, lsrao@codeaurora.org, Mahesh Sivasubramanian Subject: Re: [PATCH v5 2/4] soc: qcom: Add SoC sleep stats driver Message-ID: <20200822154542.GA254888@roeck-us.net> References: <1584505758-21037-1-git-send-email-mkshah@codeaurora.org> <1584505758-21037-3-git-send-email-mkshah@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1584505758-21037-3-git-send-email-mkshah@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Mar 18, 2020 at 09:59:16AM +0530, Maulik Shah wrote: > From: Mahesh Sivasubramanian > > Let's add a driver to read the the stats from remote processor > and export to debugfs. > > The driver creates "qcom_sleep_stats" directory in debugfs and adds > files for various low power mode available. Below is sample output > with command > > cat /sys/kernel/debug/qcom_sleep_stats/ddr > count = 0 > Last Entered At = 0 > Last Exited At = 0 > Accumulated Duration = 0 > > Signed-off-by: Mahesh Sivasubramanian > Signed-off-by: Lina Iyer > [mkshah: add subsystem sleep stats, create one file for each stat] > Signed-off-by: Maulik Shah > --- > drivers/soc/qcom/Kconfig | 9 ++ > drivers/soc/qcom/Makefile | 1 + > drivers/soc/qcom/soc_sleep_stats.c | 244 +++++++++++++++++++++++++++++++++++++ > 3 files changed, 254 insertions(+) > create mode 100644 drivers/soc/qcom/soc_sleep_stats.c > > diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig > index d0a73e7..08bc0df3 100644 > --- a/drivers/soc/qcom/Kconfig > +++ b/drivers/soc/qcom/Kconfig > @@ -185,6 +185,15 @@ config QCOM_SOCINFO > Say yes here to support the Qualcomm socinfo driver, providing > information about the SoC to user space. > > +config QCOM_SOC_SLEEP_STATS > + tristate "Qualcomm Technologies, Inc. (QTI) SoC sleep stats driver" > + depends on ARCH_QCOM && DEBUG_FS || COMPILE_TEST depends on QCOM_SMEM Otherwise causes compile error if QCOM_SMEM=n. Guenter > + help > + Qualcomm Technologies, Inc. (QTI) SoC sleep stats driver to read > + the shared memory exported by the remote processor related to > + various SoC level low power modes statistics and export to debugfs > + interface. > + > config QCOM_WCNSS_CTRL > tristate "Qualcomm WCNSS control driver" > depends on ARCH_QCOM || COMPILE_TEST > diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile > index 9fb35c8..e6bd052 100644 > --- a/drivers/soc/qcom/Makefile > +++ b/drivers/soc/qcom/Makefile > @@ -20,6 +20,7 @@ obj-$(CONFIG_QCOM_SMEM_STATE) += smem_state.o > obj-$(CONFIG_QCOM_SMP2P) += smp2p.o > obj-$(CONFIG_QCOM_SMSM) += smsm.o > obj-$(CONFIG_QCOM_SOCINFO) += socinfo.o > +obj-$(CONFIG_QCOM_SOC_SLEEP_STATS) += soc_sleep_stats.o > obj-$(CONFIG_QCOM_WCNSS_CTRL) += wcnss_ctrl.o > obj-$(CONFIG_QCOM_APR) += apr.o > obj-$(CONFIG_QCOM_LLCC) += llcc-qcom.o > diff --git a/drivers/soc/qcom/soc_sleep_stats.c b/drivers/soc/qcom/soc_sleep_stats.c > new file mode 100644 > index 0000000..0db7c3d > --- /dev/null > +++ b/drivers/soc/qcom/soc_sleep_stats.c > @@ -0,0 +1,244 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2011-2020, The Linux Foundation. All rights reserved. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +#define STAT_TYPE_ADDR 0x0 > +#define COUNT_ADDR 0x4 > +#define LAST_ENTERED_AT_ADDR 0x8 > +#define LAST_EXITED_AT_ADDR 0x10 > +#define ACCUMULATED_ADDR 0x18 > +#define CLIENT_VOTES_ADDR 0x1c > + > +struct subsystem_data { > + const char *name; > + u32 smem_item; > + u32 pid; > +}; > + > +static struct subsystem_data subsystems[] = { > + { "modem", 605, 1 }, > + { "adsp", 606, 2 }, > + { "cdsp", 607, 5 }, > + { "slpi", 608, 3 }, > + { "gpu", 609, 0 }, > + { "display", 610, 0 }, > +}; > + > +struct stats_config { > + unsigned int offset_addr; > + unsigned int num_records; > + bool appended_stats_avail; > +}; > + > +struct stats_prv_data { > + const struct stats_config *config; > + void __iomem *reg; > +}; > + > +struct sleep_stats { > + u32 stat_type; > + u32 count; > + u64 last_entered_at; > + u64 last_exited_at; > + u64 accumulated; > +}; > + > +struct appended_stats { > + u32 client_votes; > + u32 reserved[3]; > +}; > + > +static void print_sleep_stats(struct seq_file *s, struct sleep_stats *stat) > +{ > + u64 accumulated = stat->accumulated; > + /* > + * If a subsystem is in sleep when reading the sleep stats adjust > + * the accumulated sleep duration to show actual sleep time. > + */ > + if (stat->last_entered_at > stat->last_exited_at) > + accumulated += arch_timer_read_counter() > + - stat->last_entered_at; > + > + seq_printf(s, "Count = %u\n", stat->count); > + seq_printf(s, "Last Entered At = %llu\n", stat->last_entered_at); > + seq_printf(s, "Last Exited At = %llu\n", stat->last_exited_at); > + seq_printf(s, "Accumulated Duration = %llu\n", accumulated); > +} > + > +static int subsystem_sleep_stats_show(struct seq_file *s, void *d) > +{ > + struct subsystem_data *subsystem = s->private; > + struct sleep_stats *stat; > + > + stat = qcom_smem_get(subsystem->pid, subsystem->smem_item, NULL); > + if (IS_ERR(stat)) > + return PTR_ERR(stat); > + > + print_sleep_stats(s, stat); > + > + return 0; > +} > + > +static int soc_sleep_stats_show(struct seq_file *s, void *d) > +{ > + struct stats_prv_data *prv_data = s->private; > + void __iomem *reg = prv_data->reg; > + struct sleep_stats stat; > + > + stat.count = readl(reg + COUNT_ADDR); > + stat.last_entered_at = readq(reg + LAST_ENTERED_AT_ADDR); > + stat.last_exited_at = readq(reg + LAST_EXITED_AT_ADDR); > + stat.accumulated = readq(reg + ACCUMULATED_ADDR); > + > + print_sleep_stats(s, &stat); > + > + if (prv_data->config->appended_stats_avail) { > + struct appended_stats app_stat; > + > + app_stat.client_votes = readl(reg + CLIENT_VOTES_ADDR); > + seq_printf(s, "Client_votes = %#x\n", app_stat.client_votes); > + } > + > + return 0; > +} > + > +DEFINE_SHOW_ATTRIBUTE(soc_sleep_stats); > +DEFINE_SHOW_ATTRIBUTE(subsystem_sleep_stats); > + > +static struct dentry *create_debugfs_entries(void __iomem *reg, > + struct stats_prv_data *prv_data) > +{ > + struct dentry *root; > + struct sleep_stats *stat; > + char stat_type[sizeof(u32) + 1] = {0}; > + u32 offset, type; > + int i; > + > + root = debugfs_create_dir("qcom_sleep_stats", NULL); > + > + for (i = 0; i < prv_data[0].config->num_records; i++) { > + offset = STAT_TYPE_ADDR + (i * sizeof(struct sleep_stats)); > + > + if (prv_data[0].config->appended_stats_avail) > + offset += i * sizeof(struct appended_stats); > + > + prv_data[i].reg = reg + offset; > + > + type = readl(prv_data[i].reg); > + memcpy(stat_type, &type, sizeof(u32)); > + debugfs_create_file(stat_type, 0444, root, > + &prv_data[i], > + &soc_sleep_stats_fops); > + } > + > + for (i = 0; i < ARRAY_SIZE(subsystems); i++) { > + stat = qcom_smem_get(subsystems[i].pid, subsystems[i].smem_item, > + NULL); > + if (IS_ERR(stat)) > + continue; > + > + debugfs_create_file(subsystems[i].name, 0444, root, > + &subsystems[i], > + &subsystem_sleep_stats_fops); > + } > + > + return root; > +} > + > +static int soc_sleep_stats_probe(struct platform_device *pdev) > +{ > + struct resource *res; > + void __iomem *reg; > + void __iomem *offset_addr; > + phys_addr_t stats_base; > + resource_size_t stats_size; > + struct dentry *root; > + const struct stats_config *config; > + struct stats_prv_data *prv_data; > + int i; > + > + config = device_get_match_data(&pdev->dev); > + if (!config) > + return -ENODEV; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) > + return PTR_ERR(res); > + > + offset_addr = ioremap(res->start + config->offset_addr, sizeof(u32)); > + if (IS_ERR(offset_addr)) > + return PTR_ERR(offset_addr); > + > + stats_base = res->start | readl_relaxed(offset_addr); > + stats_size = resource_size(res); > + iounmap(offset_addr); > + > + reg = devm_ioremap(&pdev->dev, stats_base, stats_size); > + if (!reg) > + return -ENOMEM; > + > + prv_data = devm_kzalloc(&pdev->dev, config->num_records * > + sizeof(struct stats_prv_data), GFP_KERNEL); > + if (!prv_data) > + return -ENOMEM; > + > + for (i = 0; i < config->num_records; i++) > + prv_data[i].config = config; > + > + root = create_debugfs_entries(reg, prv_data); > + platform_set_drvdata(pdev, root); > + > + return 0; > +} > + > +static int soc_sleep_stats_remove(struct platform_device *pdev) > +{ > + struct dentry *root = platform_get_drvdata(pdev); > + > + debugfs_remove_recursive(root); > + > + return 0; > +} > + > +static const struct stats_config rpm_data = { > + .offset_addr = 0x14, > + .num_records = 2, > + .appended_stats_avail = true, > +}; > + > +static const struct stats_config rpmh_data = { > + .offset_addr = 0x4, > + .num_records = 3, > + .appended_stats_avail = false, > +}; > + > +static const struct of_device_id soc_sleep_stats_table[] = { > + { .compatible = "qcom,rpm-sleep-stats", .data = &rpm_data }, > + { .compatible = "qcom,rpmh-sleep-stats", .data = &rpmh_data }, > + { } > +}; > + > +static struct platform_driver soc_sleep_stats_driver = { > + .probe = soc_sleep_stats_probe, > + .remove = soc_sleep_stats_remove, > + .driver = { > + .name = "soc_sleep_stats", > + .of_match_table = soc_sleep_stats_table, > + }, > +}; > +module_platform_driver(soc_sleep_stats_driver); > + > +MODULE_DESCRIPTION("Qualcomm Technologies, Inc. (QTI) SoC Sleep Stats driver"); > +MODULE_LICENSE("GPL v2");